Skip to content

[stable10] Sync user_management acceptance tests in stable10#35467

Merged
phil-davis merged 1 commit into
stable10from
stable10-user_management-acceptance-tests-sync-20190610
Jun 10, 2019
Merged

[stable10] Sync user_management acceptance tests in stable10#35467
phil-davis merged 1 commit into
stable10from
stable10-user_management-acceptance-tests-sync-20190610

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 10, 2019

Copy link
Copy Markdown
Contributor

Description

Apply a few acceptance test changes from the user_management app to core stable10
See my comments for details of which user_management PR made the changes.
There are also some minor line-ending changes for some files - may as well keep those the same also!

Motivation and Context

Keep user_management acceptance tests the same in core stable10 as in the user_management app

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

use Behat\MinkExtension\Context\RawMinkContext;
use Page\LoginPage;
use Page\UsersPage;
use PHPUnit\Framework\Assert;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff comes from owncloud-archive/user_management#175

$this->waitForAjaxCallsToStartAndFinish($session);
} catch (StaleElementReference $e) {
}
$this->waitForAjaxCallsToStartAndFinish($session);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenario Outline: Add group
When the administrator adds group <groupname> using the webUI
Then the group name <groupname> should be listed on the webUI
And group <groupname> should exist

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Jun 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35467 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35467   +/-   ##
===========================================
  Coverage       64.79%   64.79%           
  Complexity      20177    20177           
===========================================
  Files            1293     1293           
  Lines           77156    77156           
  Branches         1300     1300           
===========================================
  Hits            49997    49997           
  Misses          26775    26775           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.95% <ø> (ø) 20177 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06b4a7...5f3831a. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35467 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35467   +/-   ##
===========================================
  Coverage       64.79%   64.79%           
  Complexity      20177    20177           
===========================================
  Files            1293     1293           
  Lines           77156    77156           
  Branches         1300     1300           
===========================================
  Hits            49997    49997           
  Misses          26775    26775           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.95% <ø> (ø) 20177 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06b4a7...5f3831a. Read the comment docs.

@phil-davis
phil-davis marked this pull request as ready for review June 10, 2019 14:30
@phil-davis
phil-davis merged commit a4a0a89 into stable10 Jun 10, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-user_management-acceptance-tests-sync-20190610 branch June 10, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants