Skip to content

Create multiple users in single steps in acceptance test feature files - 2#35526

Merged
dpakach merged 1 commit into
masterfrom
fix-create-user-multiple-2
Jun 14, 2019
Merged

Create multiple users in single steps in acceptance test feature files - 2#35526
dpakach merged 1 commit into
masterfrom
fix-create-user-multiple-2

Conversation

@dpakach

@dpakach dpakach commented Jun 14, 2019

Copy link
Copy Markdown
Contributor

Description

In Acceptance tests replace steps

And user "user0" has been created with default attributes and skeleton files
And user "user1" has been created with default attributes and skeleton files

By

 And these users have been created with default attributes and skeleton files:
      | username |
      | user0    |
      | user1    |

Related Issue

Motivation and Context

Same as #35525. Made in different PRs since that one was getting too long.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dpakach dpakach force-pushed the fix-create-user-multiple-2 branch from 0312df0 to 25b94dd Compare June 14, 2019 08:00
@codecov

codecov Bot commented Jun 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35526   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac7daa...25b94dd. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35526   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac7daa...25b94dd. Read the comment docs.

@dpakach

dpakach commented Jun 14, 2019

Copy link
Copy Markdown
Contributor Author

Backport on #35533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants