[stable10] Return "password fields" only if public-link password is set#35544
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #35544 +/- ##
==============================================
+ Coverage 64.8% 64.81% +<.01%
- Complexity 20201 20205 +4
==============================================
Files 1294 1294
Lines 77240 77251 +11
Branches 1301 1301
==============================================
+ Hits 50056 50070 +14
+ Misses 26799 26796 -3
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35544 +/- ##
==============================================
+ Coverage 64.81% 64.81% +<.01%
- Complexity 20204 20205 +1
==============================================
Files 1294 1294
Lines 77250 77251 +1
Branches 1301 1301
==============================================
+ Hits 50069 50070 +1
Misses 26796 26796
Partials 385 385
Continue to review full report at Codecov.
|
The iOS client uses the presence of these fields to determine if a password is required. Despite their names they are historically used to store pw-hashes for public-links.
IljaN
force-pushed
the
stable10_fix_35541
branch
from
e85f44f to
0c09977
Compare
IljaN
changed the title
Member
|
changes in test code looks good 👍 |
Contributor
|
Please port on 10.2.1 release once approved/merged |
micbar
approved these changes
Jun 17, 2019
10 tasks
Contributor
|
PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show "share_with" and "share_with_displayname" fields for public-links only if a share-password
is set.
Related Issue
Motivation and Context
The iOS client uses the presence of these fields to determine if a password is required. Despite their names they are historically used to store pw-hashes for public-links.
Due to a recent security fix (31b47dc) which replaced the hashes with
***redacted***, share_with and share_with_displayname was never null thus for the client it looked like all links have passwords.How Has This Been Tested?
Adjusted acceptance tests
Types of changes
Checklist:
Open tasks: