[master] Return "password fields" only if public-link password is set.#35545
Merged
Conversation
The iOS client uses the presence of these fields to determine if a password is required. Despite their names they are historically used to store pw-hashes for public-links.
11 tasks
IljaN
changed the title
Codecov Report
@@ Coverage Diff @@
## master #35545 +/- ##
============================================
+ Coverage 65.66% 65.66% +<.01%
- Complexity 18756 18757 +1
============================================
Files 1222 1222
Lines 70872 70873 +1
Branches 1289 1289
============================================
+ Hits 46540 46541 +1
Misses 23954 23954
Partials 378 378
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35545 +/- ##
============================================
+ Coverage 65.66% 65.66% +<.01%
- Complexity 18756 18757 +1
============================================
Files 1222 1222
Lines 70872 70873 +1
Branches 1289 1289
============================================
+ Hits 46540 46541 +1
Misses 23954 23954
Partials 378 378
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #35541
Forward port of: #35544