Skip to content

fix for users creation in ldap test - #35555

Merged
haribhandari07 merged 2 commits into
masterfrom
user_ldap_429
Jun 18, 2019
Merged

fix for users creation in ldap test#35555
haribhandari07 merged 2 commits into
masterfrom
user_ldap_429

Conversation

@haribhandari07

@haribhandari07 haribhandari07 commented Jun 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Given these users have been created with default attributes and skeleton files: # FeatureContext::theseUsersHaveBeenCreated()
step fails with
GuzzleHttp\Exception\ClientException: Client error response [url] http://server/ocs/v2.php/cloud/users [status code] 400 [reason phrase] Bad Request in /var/www/owncloud/server/lib/composer/guzzlehttp/guzzle/src/Exception/RequestException.php:89

This pull request fixes this issue owncloud/user_ldap#429

Related Issue

Fix for owncloud/user_ldap#429

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@CLAassistant

CLAassistant commented Jun 17, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@phil-davis

phil-davis commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

@haribhandari07 somehow you have got lots of l10n translation files into this PR ???

@haribhandari07 haribhandari07 self-assigned this Jun 17, 2019
@codecov

codecov Bot commented Jun 17, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #35555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35555   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18757    18757           
=========================================
  Files          1222     1222           
  Lines         70873    70873           
  Branches       1289     1289           
=========================================
  Hits          46541    46541           
  Misses        23954    23954           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.03% <ø> (ø) 18757 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8502a92...d3bd6e2. Read the comment docs.

@codecov

codecov Bot commented Jun 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #35555   +/-   ##
=======================================
  Coverage    48.9%    48.9%           
=======================================
  Files         109      109           
  Lines       10569    10569           
  Branches     1289     1289           
=======================================
  Hits         5169     5169           
  Misses       5022     5022           
  Partials      378      378
Flag Coverage Δ
#javascript 53.7% <ø> (ø) ⬆️
#phpunit 38.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddb3bc...adb7f7c. Read the comment docs.

@haribhandari07
haribhandari07 requested a review from dpakach June 18, 2019 05:21
dpakach
dpakach reviewed Jun 18, 2019
View reviewed changes

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if user_ldap tests pass then its good.

skshetry
skshetry reviewed Jun 18, 2019
View reviewed changes

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paurakhsharma
paurakhsharma reviewed Jun 18, 2019
View reviewed changes

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@haribhandari07
haribhandari07 merged commit 424fc00 into master Jun 18, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the user_ldap_429 branch June 18, 2019 07:23
@haribhandari07 haribhandari07 mentioned this pull request Jun 18, 2019
Merged
@haribhandari07

haribhandari07 commented Jun 18, 2019

Copy link
Copy Markdown
Contributor Author

Backport on #35573

@haribhandari07 haribhandari07 mentioned this pull request Jun 20, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes
+3 more reviewers
@skshetry skshetry skshetry left review comments
@dpakach dpakach dpakach left review comments
@paurakhsharma paurakhsharma paurakhsharma left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@haribhandari07 haribhandari07

Labels

4 - To release dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@haribhandari07 @CLAassistant @phil-davis @skshetry @dpakach @paurakhsharma