fix for user ldap

[haribhandari07]

Description

Fix for owncloud/user_ldap#429

Related Issue

On top of #35555

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #35609 into master will decrease coverage by 16.47%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #35609       +/-   ##
=============================================
- Coverage     65.37%    48.9%   -16.48%     
=============================================
  Files          1222      109     -1113     
  Lines         70898    10569    -60329     
  Branches       1289     1289               
=============================================
- Hits          46353     5169    -41184     
+ Misses        24167     5022    -19145     
  Partials        378      378

Flag	Coverage Δ	Complexity Δ
#javascript	53.7% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	38.29% <ø> (-28.43%)	0 <ø> (-18775)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1104 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192501e...1487286. Read the comment docs.

[codecov]

Codecov Report

Merging #35609 into master will increase coverage by 0.3%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #35609     +/-   ##
===========================================
+ Coverage     65.37%   65.68%   +0.3%     
  Complexity    18775    18775             
===========================================
  Files          1222     1222             
  Lines         70898    70932     +34     
  Branches       1289     1289             
===========================================
+ Hits          46353    46594    +241     
+ Misses        24167    23960    -207     
  Partials        378      378

Flag	Coverage Δ	Complexity Δ
#javascript	53.7% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	67.05% <ø> (+0.34%)	18775 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Cache/HomePropagator.php	77.77% <0%> (-9.73%)	3% <0%> (ø)
apps/files/lib/Command/Scan.php	71.91% <0%> (-9.17%)	74% <0%> (ø)
apps/dav/lib/Connector/Sabre/File.php	84.19% <0%> (+0.64%)	115% <0%> (ø)	⬇️
lib/private/Files/Mount/MountPoint.php	93.5% <0%> (+1.29%)	34% <0%> (ø)	⬇️
lib/private/legacy/util.php	68.19% <0%> (+2.55%)	240% <0%> (ø)	⬇️
apps/files_versions/lib/Storage.php	72.67% <0%> (+2.81%)	95% <0%> (ø)	⬇️
lib/private/Files/Storage/Common.php	85.15% <0%> (+3.33%)	141% <0%> (ø)	⬇️
apps/files_trashbin/lib/Quota.php	92% <0%> (+4%)	9% <0%> (ø)	⬇️
lib/private/Files/Type/Detection.php	74.56% <0%> (+4.38%)	52% <0%> (ø)	⬇️
lib/private/Files/Cache/Storage.php	80.45% <0%> (+4.59%)	32% <0%> (ø)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192501e...49dd476. Read the comment docs.

[dpakach]

LGTM 👍

[dpakach]

The earlier implementation did not initialize LDAP users. Because of that LDAP users would not have skeleton files and the tests failed with errors like

Then folder "simple-folder (2)" should be listed on the webUI                                    # WebUIFilesContext::fileFolderShouldBeListedOnTheWebUI()
      could not find  file 'simple-folder (2)' in current folder when it should be listed
      Failed asserting that null is not null.

That should be fixed now by initializing the users while creating them.

[haribhandari07]

Backport on #35610

[phil-davis]

I did rebase and force push. Let's see if we can get codecov status.