Skip to content

[release-10.2.1] Acceptance tests changes 2019-06-19/20/21#35591

Merged
micbar merged 11 commits into
release-10.2.1from
acceptance-tests-for-10-2-1-20190619
Jun 24, 2019
Merged

[release-10.2.1] Acceptance tests changes 2019-06-19/20/21#35591
micbar merged 11 commits into
release-10.2.1from
acceptance-tests-for-10-2-1-20190619

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Description

Backport of today's acceptance test changes from stable10 back to release-10.2.1
#35587
#35586
#35590
#35602
#35610
#35611 (unit test fix)
#35615
#35616
#35619
#35622

Motivation and Context

Have current tests in release-10.2.1 branch

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov

codecov Bot commented Jun 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35591 into release-10.2.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-10.2.1   #35591   +/-   ##
=================================================
  Coverage             64.39%   64.39%           
  Complexity            20140    20140           
=================================================
  Files                  1286     1286           
  Lines                 77078    77078           
  Branches               1308     1308           
=================================================
  Hits                  49631    49631           
  Misses                27063    27063           
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <ø> (ø) 20140 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc2883...9e38d8e. Read the comment docs.

@codecov

codecov Bot commented Jun 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35591 into release-10.2.1 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.1   #35591      +/-   ##
====================================================
- Coverage              64.4%    64.4%   -0.01%     
  Complexity            20152    20152              
====================================================
  Files                  1286     1286              
  Lines                 77107    77107              
  Branches               1308     1308              
====================================================
- Hits                  49660    49657       -3     
- Misses                27063    27066       +3     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.54% <ø> (-0.01%) 20152 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 80.46% <0%> (-0.64%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113b328...240caa8. Read the comment docs.

@phil-davis
phil-davis force-pushed the acceptance-tests-for-10-2-1-20190619 branch from 9e38d8e to 140586f Compare June 19, 2019 14:23
@phil-davis
phil-davis marked this pull request as ready for review June 19, 2019 14:24
@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport of #35590 is the one that provides the most useful test fix

@phil-davis
phil-davis force-pushed the acceptance-tests-for-10-2-1-20190619 branch from 140586f to a73b6fb Compare June 21, 2019 04:05
@phil-davis phil-davis changed the title [release-10.2.1] Acceptance tests changes 20190619 [release-10.2.1] Acceptance tests changes 2019-06-19 and 20 Jun 21, 2019
@phil-davis
phil-davis force-pushed the acceptance-tests-for-10-2-1-20190619 branch from a73b6fb to 240caa8 Compare June 21, 2019 13:49
@phil-davis phil-davis changed the title [release-10.2.1] Acceptance tests changes 2019-06-19 and 20 [release-10.2.1] Acceptance tests changes 2019-06-19/20/21 Jun 21, 2019
@phil-davis

Copy link
Copy Markdown
Contributor Author

And #35622 is also "a good thing"
@patrickjahns @micbar please merge

@micbar
micbar merged commit 035d73f into release-10.2.1 Jun 24, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the acceptance-tests-for-10-2-1-20190619 branch June 24, 2019 09:25
@patrickjahns patrickjahns modified the milestone: QA Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants