Clone testing app into apps-external#35648
Merged
Merged
Conversation
phil-davis
force-pushed
the
clone-testing-app-into-apps-external
branch
from
June 25, 2019 06:50
5ae68db to
d1e72c2
Compare
Codecov Report
@@ Coverage Diff @@
## master #35648 +/- ##
=============================================
- Coverage 65.68% 48.9% -16.79%
=============================================
Files 1222 109 -1113
Lines 70935 10569 -60366
Branches 1289 1289
=============================================
- Hits 46597 5169 -41428
+ Misses 23960 5022 -18938
Partials 378 378
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35648 +/- ##
============================================
+ Coverage 65.68% 65.73% +0.04%
Complexity 18777 18777
============================================
Files 1222 1222
Lines 70935 70899 -36
Branches 1289 1289
============================================
+ Hits 46596 46603 +7
+ Misses 23961 23918 -43
Partials 378 378
Continue to review full report at Codecov.
|
phil-davis
force-pushed
the
clone-testing-app-into-apps-external
branch
from
June 25, 2019 08:42
d1e72c2 to
82b69c4
Compare
phil-davis
force-pushed
the
clone-testing-app-into-apps-external
branch
from
June 26, 2019 10:30
82b69c4 to
0fff7bc
Compare
phil-davis
marked this pull request as ready for review
June 26, 2019 11:08
phil-davis
requested review from
dpakach,
haribhandari07,
individual-it,
paurakhsharma and
skshetry
June 26, 2019 11:08
individual-it
approved these changes
Jun 26, 2019
individual-it
left a comment
individual-it
left a comment
Member
There was a problem hiding this comment.
that should work fine, specially because now we have files-external created and configured automatically during installation
Contributor
Author
|
Backport |
delete-merged-branch
Bot
deleted the
clone-testing-app-into-apps-external
branch
June 26, 2019 13:04
This was referenced Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clone the
testingapp into theapps-externalfolder, which is where not-built-in apps should get installed anyway.Adjust
tests/lib/DB/MigrationsTest.phpso that it does not use thetestingapp as an example app for its tests. Use another one of the built-in apps - I pickedfiles_sharing.Motivation and Context
The
testingapp was put into a separate repo a few months ago.At the moment we are cloning it into the
appsfolder of core when running drone CI.The PHP unit tests scan all code in the
appsfolder looking for PHP unit tests to run - see https://github.com/owncloud/core/blob/master/tests/apps.phploadDirectory()That finds the
apps/testingfolder. So the unit tests in the testing app get run.When doing core PRs that make non-compatible PHP unit test changes (e.g. bumping to a new major version of PHP unit, and implementing new features of PHP unit etc.), then the
testingapp unit tests sometimes fail, because they are from the separatetestingapp that has not had its unit test code updated yet.How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: