You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "real core" apps are known to be in the apps folder. When scanning enabled apps for unit tests, only consider apps found in the apps folder.
Note: by convention, developers and other CI scripts... should be installing extra apps in some other folder like apps-external
Motivation and Context
The testing app in drone was move from apps to apps-external by PR #35648 - that was intended to avoid the unit tests o the testing app being accidentally run by core unit test jobs.
It turns out that the testing app unit tests are still being run in core drone. That is because the testing app is enabled, and the unit test script runs test cases for all enabled apps.
When core unit tests are being run, we really just want to run test cases for the "real core" apps. For other apps from separate repos, that happen to be installed and enabled, we do not want to run their unit test cases. Because those might fail - e.g. we are preparing a PHP unit major version upgrade, or...)
How Has This Been Tested?
CI
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)
Checklist:
Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:
Open tasks:
Backport (if applicable set "backport-request" label and remove when the backport was done)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "real core" apps are known to be in the
appsfolder. When scanning enabled apps for unit tests, only consider apps found in theappsfolder.Note: by convention, developers and other CI scripts... should be installing extra apps in some other folder like
apps-externalMotivation and Context
The
testingapp in drone was move fromappstoapps-externalby PR #35648 - that was intended to avoid the unit tests o thetestingapp being accidentally run by core unit test jobs.It turns out that the
testingapp unit tests are still being run in core drone. That is because the testing app is enabled, and the unit test script runs test cases for all enabled apps.When core unit tests are being run, we really just want to run test cases for the "real core" apps. For other apps from separate repos, that happen to be installed and enabled, we do not want to run their unit test cases. Because those might fail - e.g. we are preparing a PHP unit major version upgrade, or...)
How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: