Load PHPunit app tests in alphabetical order#35665
Merged
Merged
Conversation
Contributor
Author
|
CI has got some of the out-of-memory errors that we have also been getting the last few days. I will restart and see if we can get lucky with those. |
This was referenced Jun 26, 2019
Contributor
Author
|
drone is happy - great! |
Contributor
Author
|
Backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When finding the unit tests for the built-in core apps, use
scandir()so that the relevant folders and files are discovered and loaded in a predictable order - in this case it will be alphabetical order.At least this will mean that the unit test runs will more reliably either pass or fail. There will not be the potential for "random" failures due to the order of test case execution.
Related Issue
#35658
Motivation and Context
We are getting intermittent unit test fails in CI. Actually those fails are because
apps/files_sharing/tests/External/ManagerTest.phptestAddShareAcceptedis not cleaning up the share that it creates.If that happens to run before
apps/files_sharing/tests/Commands/CleanupRemoteStoragesTestthenCleanupRemoteStoragesTestfails because its environment starts out with an extra unexepected entry inshare_externaltable.apps/files_sharing/tests/External/ManagerTest.phpcan be fixed in a separate PR.How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: