Skip to content

[Tests-Only] Implement guzzle6 in acceptance tests#36946

Closed
phil-davis wants to merge 13 commits into
masterfrom
bump-acceptance-test-dependencies
Closed

[Tests-Only] Implement guzzle6 in acceptance tests#36946
phil-davis wants to merge 13 commits into
masterfrom
bump-acceptance-test-dependencies

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

To be written. These acceptance test changes have been taken from old Guzzle PR #32537 and then worked on to (hopefully) work in the current core master. There was a lot of stuff to do related to supporting the "batch request" stuff that was done in core acceptance test code a few months ago to speed it up, because that functionality is quite a bit changed in Guzzle 6.

Let's see what happens in CI.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov

codecov Bot commented Feb 12, 2020

Copy link
Copy Markdown

Codecov Report

Merging #36946 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36946   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19138    19138           
=========================================
  Files          1270     1270           
  Lines         74912    74912           
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
  Misses        26014    26014           
  Partials        391      391           
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0.00 <ø> (ø) ⬆️
#phpunit 65.92% <ø> (+0.77%) 19138.00 <ø> (ø) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 77.77% <0.00%> (ø) 3.00% <0.00%> (ø%) ⬆️
apps/files/lib/Command/Scan.php 71.92% <0.00%> (ø) 61.00% <0.00%> (ø%) ⬆️
lib/private/Files/View.php 84.83% <0.00%> (ø) 389.00% <0.00%> (ø%) ⬆️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0.00%> (ø) 68.00% <0.00%> (ø%) ⬆️
apps/dav/lib/Connector/Sabre/File.php 84.19% <0.00%> (ø) 115.00% <0.00%> (ø%) ⬆️
lib/private/DB/Connection.php 67.64% <0.00%> (ø) 49.00% <0.00%> (ø%) ⬆️
lib/private/DB/MDB2SchemaWriter.php 94.79% <0.00%> (ø) 34.00% <0.00%> (ø%) ⬆️
lib/private/DB/MDB2SchemaManager.php 91.22% <0.00%> (ø) 17.00% <0.00%> (ø%) ⬆️
lib/private/Files/Cache/Cache.php 97.64% <0.00%> (ø) 106.00% <0.00%> (ø%) ⬆️
lib/private/AllConfig.php 96.22% <0.00%> (ø) 43.00% <0.00%> (ø%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cddc94...c8af65e. Read the comment docs.

@phil-davis phil-davis force-pushed the bump-acceptance-test-dependencies branch 4 times, most recently from 7a40e54 to 10d78a8 Compare February 18, 2020 16:14
@phil-davis phil-davis force-pushed the bump-acceptance-test-dependencies branch 2 times, most recently from 903a5d6 to 6b14940 Compare February 21, 2020 07:46
@phil-davis phil-davis force-pushed the bump-acceptance-test-dependencies branch from fe4e821 to c8af65e Compare February 21, 2020 10:34
@phil-davis

Copy link
Copy Markdown
Contributor Author

See #36999 for the squashed version of this that is ready for review...

@phil-davis phil-davis closed this Feb 21, 2020
@phil-davis phil-davis deleted the bump-acceptance-test-dependencies branch March 12, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant