Skip to content

PHP 7.4 20200310#37101

Closed
phil-davis wants to merge 3 commits into
masterfrom
php7.4-20200310
Closed

PHP 7.4 20200310#37101
phil-davis wants to merge 3 commits into
masterfrom
php7.4-20200310

Conversation

@phil-davis

@phil-davis phil-davis commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

This is code so far for supporting PHP 7.4

There are a lot of adjustments to phpunit tests still to be done - but I think the actual run-time back-end works.

Previous PRs like this were #37004 and #36855

@phil-davis phil-davis self-assigned this Mar 10, 2020
@phil-davis phil-davis mentioned this pull request Mar 10, 2020
@codecov

codecov Bot commented Mar 13, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@ef0d983). Click here to learn what that means.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37101   +/-   ##
=========================================
  Coverage          ?   65.53%           
  Complexity        ?    19293           
=========================================
  Files             ?     1220           
  Lines             ?    71911           
  Branches          ?     1328           
=========================================
  Hits              ?    47125           
  Misses            ?    24396           
  Partials          ?      390
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (?) 0 <ø> (?)
#phpunit 66.85% <12.5%> (?) 19293 <0> (?)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Cache.php 97.64% <ø> (ø) 106 <0> (?)
index.php 0% <0%> (ø) 0 <0> (?)
console.php 0% <0%> (ø) 0 <0> (?)
...AppFramework/Utility/ControllerMethodReflector.php 100% <100%> (ø) 10 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef0d983...c91ffc1. Read the comment docs.

@mrow4a

mrow4a commented Mar 28, 2020

Copy link
Copy Markdown
Contributor

@phil-davis do you need help in getting unittests fixed?

@phil-davis

Copy link
Copy Markdown
Contributor Author

I was not tasked with this. It is a community contribution. So if anybody wants to do this sort of work towards PHP 7.4 support - feel free to do it.

See #37169 and and #36586 - those are both waiting for review and have some related stuff already.

@phil-davis

Copy link
Copy Markdown
Contributor Author

I rebased just now, so that this is up-to-date with dependencies and other stuff in master.

@phil-davis phil-davis force-pushed the php7.4-20200310 branch 3 times, most recently from 795c7d5 to e87f944 Compare April 17, 2020 15:58
@phil-davis phil-davis force-pushed the php7.4-20200310 branch 2 times, most recently from ae10d30 to 8ed0f81 Compare April 21, 2020 08:01
@phil-davis

Copy link
Copy Markdown
Contributor Author

I rebased again just now. This branch is being used to help run app acceptance tests with PHP 7.4 - I will keep this branch here to support that for the next few days.

The actual fixing of phpunit fails is now being done by @VicDeo in PR #37280

@phil-davis

Copy link
Copy Markdown
Contributor Author

PHP 7.4 support has been merged in master now.

@phil-davis phil-davis closed this Apr 25, 2020
@juanpablopwr

Copy link
Copy Markdown

when are you planning to release version 10.5.0 for php 7.4.4?

@VicDeo VicDeo deleted the php7.4-20200310 branch May 19, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants