[Tests-Only] Php 7.4 fix phpunit#37280
Closed
VicDeo wants to merge 4 commits into
Closed
Conversation
Contributor
|
@VicDeo I merged PR #37281 and there were some other unrelated dependency updates overnight that are merged PR #37283 Then you can rebase this PR and get a new run of phpunit with less errors reported. |
VicDeo
force-pushed
the
php-7.4-fix-phpunit
branch
2 times, most recently
from
23cb107 to
bc737a2
Compare
Closed
VicDeo
force-pushed
the
php-7.4-fix-phpunit
branch
9 times, most recently
from
e2d65e6 to
3534d51
Compare
VicDeo
force-pushed
the
php-7.4-fix-phpunit
branch
from
3534d51 to
540b0cc
Compare
VicDeo
force-pushed
the
php-7.4-fix-phpunit
branch
from
0cd9e0a to
0f86aa4
Compare
Codecov Report
@@ Coverage Diff @@
## master #37280 +/- ##
============================================
- Coverage 64.52% 64.48% -0.04%
Complexity 19166 19166
============================================
Files 1266 1266
Lines 74936 74952 +16
Branches 1331 1331
============================================
- Hits 48354 48335 -19
- Misses 26190 26225 +35
Partials 392 392
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #37280 +/- ##
============================================
- Coverage 64.52% 64.48% -0.04%
Complexity 19166 19166
============================================
Files 1266 1266
Lines 74936 74952 +16
Branches 1331 1331
============================================
- Hits 48354 48335 -19
- Misses 26190 26225 +35
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #37280 +/- ##
============================================
- Coverage 64.52% 64.48% -0.04%
Complexity 19166 19166
============================================
Files 1266 1266
Lines 74936 74952 +16
Branches 1331 1331
============================================
- Hits 48354 48335 -19
- Misses 26190 26225 +35
Partials 392 392
Continue to review full report at Codecov.
|
11 tasks
Contributor
Contributor
|
See PR #37302 for a PR to enable PHP 7.4 in core. IMO CI should pass there. |
Contributor
Author
|
All known issues have been fixed. it's time to close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: