Skip to content

[tests-only] test the OCIS implementation of the previews - #37260

Merged
phil-davis merged 1 commit into
masterfrom
testSkipOnOcisWebDavPreview
Apr 16, 2020
Merged

[tests-only] test the OCIS implementation of the previews#37260
phil-davis merged 1 commit into
masterfrom
testSkipOnOcisWebDavPreview

Conversation

@swoichha

@swoichha swoichha commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

Description

Test the OCIS implementation of the WebDAV API previews test for testing the previews of different types of files like text, images, pdf, etc. with valid as well as invalid preview size.

Related Issue

Motivation and Context

  • To test the OCIS implementation of the previews

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov

codecov Bot commented Apr 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #37260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37260   +/-   ##
=========================================
  Coverage     64.92%   64.92%           
  Complexity    19151    19151           
=========================================
  Files          1267     1267           
  Lines         74902    74902           
  Branches       1331     1331           
=========================================
  Hits          48633    48633           
  Misses        25877    25877           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.13% <ø> (ø) 19151.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bec7a3...b0e8c34. Read the comment docs.

@Talank Talank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis
phil-davis merged commit 5115f53 into master Apr 16, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the testSkipOnOcisWebDavPreview branch April 16, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants