Skip to content

[Tests-Only] Skip on oc v10 for special ocis preview scenarios - #37274

Merged
individual-it merged 2 commits into
masterfrom
skipOnOcV10-for-special-ocis-preview-scenarios
Apr 17, 2020
Merged

[Tests-Only] Skip on oc v10 for special ocis preview scenarios#37274
individual-it merged 2 commits into
masterfrom
skipOnOcV10-for-special-ocis-preview-scenarios

Conversation

@phil-davis

@phil-davis phil-davis commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Description

  1. some test scenarios for previews in OCIS were added in [tests-only] test the OCIS implementation of the previews #37260 They should always be skipped on oC V10. That was not happening and nightly test runs failed, e.g. https://drone.owncloud.com/owncloud/activity/1205/70/14
--- Failed scenarios:

    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:46
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:47
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:48
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:49
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:50
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:51
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:52
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:79
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:80
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:81
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:82
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:83
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:84
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:85
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:253

54 scenarios (39 passed, 15 failed)
297 steps (282 passed, 15 failed)

Skip those on OcV10

  1. the apiWebdavPreviews suite is not actually running in core CI. That is why we did not discover this problem in core! Add it to CI.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis

Copy link
Copy Markdown
Contributor Author

https://drone.owncloud.com/owncloud/core/24312/64/13
apiWebdavPreviews runs in CI and passes - great stuff.

@codecov

codecov Bot commented Apr 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #37274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37274   +/-   ##
=========================================
  Coverage     64.92%   64.92%           
  Complexity    19151    19151           
=========================================
  Files          1267     1267           
  Lines         74902    74902           
  Branches       1331     1331           
=========================================
  Hits          48633    48633           
  Misses        25877    25877           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.13% <ø> (ø) 19151.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea9d57...644a8a7. Read the comment docs.

@individual-it
individual-it merged commit a3fef87 into master Apr 17, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the skipOnOcV10-for-special-ocis-preview-scenarios branch April 17, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants