Check get result against false when removing file from cache#37281
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Codecov Report
@@ Coverage Diff @@
## master #37281 +/- ##
=========================================
Coverage 64.52% 64.52%
- Complexity 19155 19156 +1
=========================================
Files 1266 1266
Lines 74912 74913 +1
Branches 1331 1331
=========================================
+ Hits 48340 48341 +1
Misses 26180 26180
Partials 392 392
Continue to review full report at Codecov.
|
phil-davis
approved these changes
Apr 21, 2020
This was referenced Apr 21, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is critical for unit tests to pass with PHP 7.4
Related Issue
https://github.com/owncloud/enterprise/issues/3967
Motivation and Context
Many unit tests are failing for PHP 7.4
Before https://drone.owncloud.com/owncloud/core/24348/24/9:
After https://drone.owncloud.com/owncloud/core/24349/24/9
How Has This Been Tested?
By CI
Types of changes
Checklist: