setting for recursive extra config.php search

[mrow4a]

Description

Feature: setting for recursive extra config.php search

Before this change extra config.php files were required to be placed directly in the config folder.
This change allows to have nested folders configuration structure, enabled by config value OC_CONFIG_EXTRA_RECURSIVE_SEARCH, that can be useful in some deployments.

NOTE: due to the fact that this configuration control setting the configuration itself, it is only possible to enable this setting with environment variable, it is not possible to enable it with *.config.php file.

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/5406

How Has This Been Tested?

• manually in the developer instance

-> add nested config
-> Update entry in /etc/apache2/sites-available/owncloud.conf with SetEnv OC_CONFIG_EXTRA_RECURSIVE_SEARCH true
@d7oc NOTE: probably in your case it needs to be Dockefile env, but you would need to test this. In owncloud code we do not care how env is provided, as soon as it is provided by methods allowed by deployment (docker, apache2, etc..).
-> check that config is applied

• unit/acceptance tests

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• Base code changes
• Unit tests added
• Acceptance tests added
• Changelog item, see TEMPLATE

[ownclouders]

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/36968/114

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[mrow4a]

@phil-davis has something changed to SonarCloud? I have full coverage for the code, and sonar says 0%. Somehow my unit test was not detected?

[phil-davis]

@phil-davis has something changed to SonarCloud? I have full coverage for the code, and sonar says 0%. Somehow my unit test was not detected?

Thanks for letting me know. Should be fixed by #40415

[mmattel]

@mrow4a the new config parameter config_extra_recursive_search needs to be added in config/config.sample.php. See the file for details, maybe in section All other configuration options.
Also file an issue in docs-server so we can do a config-to-docs run transporting the changes to docs.

[mrow4a]

@mmattel not true, check description. it is not possible to add this to any of *.config.php, it can only be enabled using ENV variable

NOTE: due to the fact that this configuration control setting the configuration itself, it is only possible to enable this setting with environment variable, it is not possible to enable it with *.config.php file.

however, I am not sure if we ever merge this PR.. seems no longer needed for related deployment

[pako81]

@d7oc is this still needed?

[d7oc]

Not from my side. See my comment in https://github.com/owncloud/enterprise/issues/5406#issuecomment-1274719083