Skip to content

[tests-only] Fix file names used for SonarCloud code coverage in CI#40415

Merged
phil-davis merged 2 commits into
masterfrom
fix-phpunit-code-coverage
Oct 12, 2022
Merged

[tests-only] Fix file names used for SonarCloud code coverage in CI#40415
phil-davis merged 2 commits into
masterfrom
fix-phpunit-code-coverage

Conversation

@phil-davis

@phil-davis phil-davis commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Description

PR #40409 changed the PHP docker image to Ubuntu 20.04. A side-effect was that the drone CI naming of the coverage result files changed, and so coverage did not get correctly sent to SonarCloud.

The coverage result files are named based on the unit test pipeline names (that ensures that they have unique names). This PR puts the names back to just having php7.4 (rather than php7.4-ubuntu20.04). That will shorten the pipeline names, and also make the coverage result file names match what is in sonar-project.properties

I also removed some duplicates in sonar-project.properties

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
phil-davis merged commit 74c4311 into master Oct 12, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the fix-phpunit-code-coverage branch October 12, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants