[tests-only] Fix file names used for SonarCloud code coverage in CI#40415
Merged
Conversation
5 tasks
mrow4a
approved these changes
Oct 11, 2022
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
PR #40409 changed the PHP docker image to Ubuntu 20.04. A side-effect was that the drone CI naming of the coverage result files changed, and so coverage did not get correctly sent to SonarCloud.
The coverage result files are named based on the unit test pipeline names (that ensures that they have unique names). This PR puts the names back to just having
php7.4(rather thanphp7.4-ubuntu20.04). That will shorten the pipeline names, and also make the coverage result file names match what is insonar-project.propertiesI also removed some duplicates in
sonar-project.propertiesHow Has This Been Tested?
CI
Types of changes
Checklist: