Skip to content

[tests-only] [full-ci] Run some CI pipelines with Ubuntu 22 - #40747

Merged
phil-davis merged 1 commit into
masterfrom
ci-ubuntu22
Apr 22, 2023
Merged

[tests-only] [full-ci] Run some CI pipelines with Ubuntu 22#40747
phil-davis merged 1 commit into
masterfrom
ci-ubuntu22

Conversation

@phil-davis

@phil-davis phil-davis commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

Description

We support oC10.12 with PHP 7.4 running on Ubuntu 20.04 or 22.04. We have been running all the tests (unit, litmus, acceptance...) with Ubuntu 20.04. We also want to know that there are not regressions when running on Ubuntu 22.04. There is an owncloud-ci/php docker image that is based on Ubuntu 22.04 with the necessary things done to install PHP 7.4 (rather than PHP 8), and to set up openssl so that legacy encryption methods are enabled. These are the things that also have to be done on
a production Ubuntu 22.04 system to run oC10.12.

This PR adds some test pipelines to CI that run on Ubuntu 22.04:

  • PHP unit tests with sqlite and with Maria DB (note that the existing scripts automagically run all tests for the sqlite case and only the tests tagged with group DB in the MariaDB case, so that is why I have added both pipelines)
  • cliEncryption test suite (because that verifies that encryption+openssl are working OK)
  • API acceptance smoke tests

I think that is enough test pipelines to run to help notice any regressions due to the Ubuntu 22.04 settings.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
phil-davis force-pushed the ci-ubuntu22 branch 2 times, most recently from 0f178ba to 2acede2 Compare April 19, 2023 08:29
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
phil-davis marked this pull request as ready for review April 19, 2023 12:48
@phil-davis phil-davis self-assigned this Apr 19, 2023

@SwikritiT SwikritiT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
phil-davis merged commit 605037a into master Apr 22, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the ci-ubuntu22 branch April 22, 2023 12:59
DeepDiver1975 added a commit that referenced this pull request Feb 17, 2026
This reverts commit 605037a, reversing
changes made to e9cb5fd.
DeepDiver1975 added a commit that referenced this pull request Feb 25, 2026
This reverts commit 605037a, reversing
changes made to e9cb5fd.
DeepDiver1975 added a commit that referenced this pull request Feb 26, 2026
This reverts commit 605037a, reversing
changes made to e9cb5fd.
DeepDiver1975 added a commit that referenced this pull request Mar 2, 2026
This reverts commit 605037a, reversing
changes made to e9cb5fd.
DeepDiver1975 added a commit that referenced this pull request Mar 9, 2026
* feat: php 8.2

* fix: param declarations and deprecations

* chore: move adjustments

* ci: adjust .drone.star format

* feat: fix phpstan & phan

* fix: style & phan

* fix: add oc version back to DefinitionParameter::jsonSerialize

* fix: more php8.x deprecations

* fix: more php8.x deprecations

* fix: preview generation

* fix: more fixes ....

* fix: ShareTest and MemcacheLockingProvider

* fix: drop ext-apc - this is unused for decades

* fix: cache tests + usage of TestCase::getUniqueID()

* fix: dynamic properties

* feat: move php version check to base.php

* fix: installation on MySql

* fix: MigratorTest for MySQL

* chore: write log messagen an exception to error_log in case of exception during Log::writeExtra

* fix: Share20OcsController

* fix: Dispatcher/DispatcherTest

* fix: Http and tests

* fix: more deprcations ...

* fix: UserControllerTest

* fix: owncloud log command tests

* fix: more deprecation warnings

* chore: 💤

* chore: migrate to symfony/mailer

chore: remove email config `mail_smtpauthtype` - this is now auto detected

fix: Mailer::send will always thrown an exception in case of errors during delivery

* fix: mail logger method signature

* fix: make OC_image::loadFromBase64 public again

* feat: php 8.3

* fix: Query::jsonSerialize() return type

* Revert "Merge pull request #40747 from owncloud/ci-ubuntu22"

This reverts commit 605037a, reversing
changes made to e9cb5fd.

* fix: php 8.3 is min version

* fix: QueryLogger::getMicrotime() returns int

* fix: MySQLPlatform casing and MapperTest

* fix: composer update + remove roave/security-advisories for the time being - firebase/php-jwt requires major update

* ci: use php 8.3 in GH workflows as well

* fix: SVG preview generation

* fix: Office preview generation + fixing CryptoSessionDataTest

* fix: deprecations in ViewTest

* fix: mysql setup

* ci: use owncloudci/core:83 image for federation tests

* fix: Request::getParams()

* feat: update firebase/php-jwt 7+ (#41473)

* chore(deps): firebase/php-jwt google/apiclient and symfony/*

* fix: adjust symfony run to make it compatible

* fix: adjust function declaration to be compatible

* fix: adjust functions for compatibility

* fix: help phan with the missing helper types

* fix: replace maps to callbacks in tests to fix return types

* fix: wrong tablenode in acceptance tests

* fix: replace deprecated "application->add" with "addCommand"

* fix: add null type to the failing system config set test

* fix: add default empty value to the list group command

* ci: use correct docker image owncloudci/core:php83

* ci: use different docker core images for different code versions as running the federated server

* ci: fix federated server setup

* ci: fix federated server setup

* test: fix str_replace in WenUISharingContext::thePublicAccessesTheLastCreatedPublicLinkUsingTheWebUI()

* test: ignore failing test ApiTest::testShareStorageMountPoint() under Oracle

* fix: change wrong test expectation for previews

* ci: disable code coverage due to issues with the cache

* test: skip preview test issue 41480

* fix: federation ci (#41481)

* chore(ci): use PHP 8.3 for federated server installed from git

For the test configuration where we use a federated server that is
running the same code as the code in this PR, we need to use PHP 8.3.

Other federated server configurations test against existing releases
of oC10, and for those we need to use PHP 7.4

* chore(ci): fixup setting of federated PHP version

Decide the PHP version needed for the federated server once and
pass it to the drone starlark functions that need it.

---------

Co-authored-by: Phil Davis <phil@jankaritech.com>
Co-authored-by: Juan Pablo Villafañez <jpvillafanez@izertis.com>
Co-authored-by: Juan Pablo Villafáñez <jvillafanez@solidgeargroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants