Skip to content

Feat/php8 again jwt update - #41473

Merged
DeepDiver1975 merged 6 commits into
feat/php8-againfrom
feat/php8-again_jwt-update
Mar 3, 2026
Merged

Feat/php8 again jwt update#41473
DeepDiver1975 merged 6 commits into
feat/php8-againfrom
feat/php8-again_jwt-update

Conversation

@jvillafanez

@jvillafanez jvillafanez commented Feb 27, 2026

Copy link
Copy Markdown
Member

Description

Dependency update of firebase/php-jwt to version 7.

google/apiclient required update due to php-jwt update:

  Problem 1
    - Root composer.json requires firebase/php-jwt ^7, found firebase/php-jwt[v7.0.0, v7.0.1, v7.0.2, v7.0.3] but these were not loaded, likely because it conflicts with another require.
  Problem 2
    - google/apiclient is locked to version v2.19.0 and an update of this package was not requested.
    - google/apiclient v2.19.0 requires firebase/php-jwt ^6.0||^7.0 -> found firebase/php-jwt[v6.0.0, ..., v6.11.1, v7.0.0, v7.0.1, v7.0.2, v7.0.3] but these were not loaded, likely because it conflicts with another require.

symfony packages required upgrade due to a conflict with the psr/log, which required upgrade for google/apiclient:

  Problem 1
    - Root composer.json requires google/apiclient ^2 -> satisfiable by google/apiclient[v2.0.0, ..., v2.19.0].
    - symfony/console is locked to version v5.4.47 and an update of this package was not requested.
    - google/apiclient[v2.0.0, ..., v2.0.3] require firebase/php-jwt ~2.0|~3.0 -> found firebase/php-jwt[2.0.0, v2.1.0, v2.2.0, v3.0.0] but it conflicts with your root composer.json require (^7).
    - google/apiclient[v2.1.0, ..., v2.1.3] require firebase/php-jwt ~2.0|~3.0|~4.0 -> found firebase/php-jwt[2.0.0, v2.1.0, v2.2.0, v3.0.0, v4.0.0] but it conflicts with your root composer.json require (^7).
    - google/apiclient[v2.2.0, ..., v2.12.1] require firebase/php-jwt ~2.0||~3.0||~4.0||~5.0 -> found firebase/php-jwt[2.0.0, v2.1.0, v2.2.0, v3.0.0, v4.0.0, v5.0.0, ..., v5.5.1] but it conflicts with your root composer.json require (^7).
    - google/apiclient[v2.12.2, ..., v2.14.0] require firebase/php-jwt ~2.0||~3.0||~4.0||~5.0||~6.0 -> found firebase/php-jwt[2.0.0, v2.1.0, v2.2.0, v3.0.0, v4.0.0, v5.0.0, ..., v5.5.1, v6.0.0, ..., v6.11.1] but it conflicts with your root composer.json require (^7).
    - google/apiclient[v2.15.0, ..., v2.16.1] require firebase/php-jwt ~6.0 -> found firebase/php-jwt[v6.0.0, ..., v6.11.1] but it conflicts with your root composer.json require (^7).
    - google/apiclient[v2.17.0, ..., v2.18.4] require firebase/php-jwt ^6.0 -> found firebase/php-jwt[v6.0.0, ..., v6.11.1] but it conflicts with your root composer.json require (^7).
    - google/auth[v1.35.0, ..., v1.49.0] require firebase/php-jwt ^6.0 -> found firebase/php-jwt[v6.0.0, ..., v6.11.1] but it conflicts with your root composer.json require (^7).
    - google/apiclient v2.19.0 requires google/auth ^1.37 -> satisfiable by google/auth[v1.37.0, ..., v1.50.0].
    - google/auth v1.50.0 requires psr/log ^3.0 -> satisfiable by psr/log[3.0.0, 3.0.1, 3.0.2].
    - symfony/console v5.4.47 conflicts with psr/log 3.0.2.

In addition, "core/Command/Base.php" required adjustment due to the symfony upgrade

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Notes:

Deprecated warning appeared:

{"reqId":"L4vYDRNlAzI4j5D9gEVh","level":3,"time":"2026-02-27T13:03:59+00:00","remoteAddr":"","user":"--","app":"PHP","method":"GET","url":"--","message":"Since symfony\/console 7.4: The \"Symfony\\Component\\Console\\Application::add()\" method is deprecated and will be removed in Symfony 8.0, use \"Symfony\\Component\\Console\\Application::addCommand()\" instead. at \/var\/www\/owncloud\/lib\/composer\/symfony\/deprecation-contracts\/function.php#25"}

Seemly unrelated errors happening (to be checked at some point):

{"reqId":"juDEIr4Gnt5CZufcJalx","level":3,"time":"2026-02-27T13:12:13+00:00","remoteAddr":"10.0.2.28","user":"admin","app":"PHP","method":"GET","url":"\/index.php\/settings\/admin?sectionid=general","message":"Implicit conversion from float-string \"1772197441.677\" to int loses precision at \/var\/www\/owncloud\/lib\/private\/DateTimeFormatter.php#84"}
{"reqId":"uolDclUazHBQED4MXpCI","level":3,"time":"2026-02-27T13:19:50+00:00","remoteAddr":"10.0.2.28","user":"admin","app":"PHP","method":"GET","url":"\/remote.php\/dav\/files\/admin\/Funny-Laugh-A4-www.fesliyanstudios.com.mp3?c=8248cc5f576b7d0422d126b18e41c98e&x=32&y=32&forceIcon=0&preview=1","message":"imagecreatefromstring(): Data is not in a recognized format at \/var\/www\/owncloud\/lib\/private\/legacy\/image.php#730"}

@jvillafanez jvillafanez self-assigned this Feb 27, 2026
@update-docs

update-docs Bot commented Feb 27, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez
jvillafanez force-pushed the feat/php8-again_jwt-update branch from fe8ce25 to 32a86b2 Compare March 2, 2026 10:45
@jvillafanez
jvillafanez marked this pull request as ready for review March 2, 2026 12:28
@jvillafanez
jvillafanez force-pushed the feat/php8-again_jwt-update branch from ed27724 to 61cb994 Compare March 2, 2026 14:54
@DeepDiver1975
DeepDiver1975 merged commit 9d91ef7 into feat/php8-again Mar 3, 2026
8 of 9 checks passed
@DeepDiver1975
DeepDiver1975 deleted the feat/php8-again_jwt-update branch March 3, 2026 08:15
DeepDiver1975 added a commit that referenced this pull request Mar 9, 2026
* feat: php 8.2

* fix: param declarations and deprecations

* chore: move adjustments

* ci: adjust .drone.star format

* feat: fix phpstan & phan

* fix: style & phan

* fix: add oc version back to DefinitionParameter::jsonSerialize

* fix: more php8.x deprecations

* fix: more php8.x deprecations

* fix: preview generation

* fix: more fixes ....

* fix: ShareTest and MemcacheLockingProvider

* fix: drop ext-apc - this is unused for decades

* fix: cache tests + usage of TestCase::getUniqueID()

* fix: dynamic properties

* feat: move php version check to base.php

* fix: installation on MySql

* fix: MigratorTest for MySQL

* chore: write log messagen an exception to error_log in case of exception during Log::writeExtra

* fix: Share20OcsController

* fix: Dispatcher/DispatcherTest

* fix: Http and tests

* fix: more deprcations ...

* fix: UserControllerTest

* fix: owncloud log command tests

* fix: more deprecation warnings

* chore: 💤

* chore: migrate to symfony/mailer

chore: remove email config `mail_smtpauthtype` - this is now auto detected

fix: Mailer::send will always thrown an exception in case of errors during delivery

* fix: mail logger method signature

* fix: make OC_image::loadFromBase64 public again

* feat: php 8.3

* fix: Query::jsonSerialize() return type

* Revert "Merge pull request #40747 from owncloud/ci-ubuntu22"

This reverts commit 605037a, reversing
changes made to e9cb5fd.

* fix: php 8.3 is min version

* fix: QueryLogger::getMicrotime() returns int

* fix: MySQLPlatform casing and MapperTest

* fix: composer update + remove roave/security-advisories for the time being - firebase/php-jwt requires major update

* ci: use php 8.3 in GH workflows as well

* fix: SVG preview generation

* fix: Office preview generation + fixing CryptoSessionDataTest

* fix: deprecations in ViewTest

* fix: mysql setup

* ci: use owncloudci/core:83 image for federation tests

* fix: Request::getParams()

* feat: update firebase/php-jwt 7+ (#41473)

* chore(deps): firebase/php-jwt google/apiclient and symfony/*

* fix: adjust symfony run to make it compatible

* fix: adjust function declaration to be compatible

* fix: adjust functions for compatibility

* fix: help phan with the missing helper types

* fix: replace maps to callbacks in tests to fix return types

* fix: wrong tablenode in acceptance tests

* fix: replace deprecated "application->add" with "addCommand"

* fix: add null type to the failing system config set test

* fix: add default empty value to the list group command

* ci: use correct docker image owncloudci/core:php83

* ci: use different docker core images for different code versions as running the federated server

* ci: fix federated server setup

* ci: fix federated server setup

* test: fix str_replace in WenUISharingContext::thePublicAccessesTheLastCreatedPublicLinkUsingTheWebUI()

* test: ignore failing test ApiTest::testShareStorageMountPoint() under Oracle

* fix: change wrong test expectation for previews

* ci: disable code coverage due to issues with the cache

* test: skip preview test issue 41480

* fix: federation ci (#41481)

* chore(ci): use PHP 8.3 for federated server installed from git

For the test configuration where we use a federated server that is
running the same code as the code in this PR, we need to use PHP 8.3.

Other federated server configurations test against existing releases
of oC10, and for those we need to use PHP 7.4

* chore(ci): fixup setting of federated PHP version

Decide the PHP version needed for the federated server once and
pass it to the drone starlark functions that need it.

---------

Co-authored-by: Phil Davis <phil@jankaritech.com>
Co-authored-by: Juan Pablo Villafañez <jpvillafanez@izertis.com>
Co-authored-by: Juan Pablo Villafáñez <jvillafanez@solidgeargroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants