OC_VCategories => OC\Tags. Public interface and getter in server container

[tanghus]

Stripped VObject specific stuff out of the class to make it an all-purpose tagging lib.

An instance can be obtained by $server->getTagManager()->loadTagsFor('type');

@georgehrke @DeepDiver1975 @icewind1991 @karlitschek

[DeepDiver1975]

addMultiple
addRange
addSet
???

[tanghus]

Neither are very good, but I'll expand it to addMultiple :)

[tanghus]

Thanks for reviewing and fixing @DeepDiver1975
I've updated to (most of) your suggestions and added two more tests.

[tanghus]

Hmm, test passes locally.

[DeepDiver1975]

@tanghus it's causing issues on Oracle

00:26:34.723 
00:26:40.016 Testing with oci ...
00:26:41.421 PHPUnit 3.7.21 by Sebastian Bergmann.
00:26:41.421 
00:26:41.421 Configuration read from /var/lib/jenkins/jobs/pull-request-analyser/workspace/tests/phpunit-autotest.xml
00:26:41.421 
00:26:41.429 ...............................................................  63 / 659 (  9%)
00:26:42.219 ............................................................... 126 / 659 ( 19%)
00:26:42.777 ....................S.......................................... 189 / 659 ( 28%)
00:28:19.234 ............................................................... 252 / 659 ( 38%)
00:28:33.069 ............................................................... 315 / 659 ( 47%)
00:28:39.506 ............................................................... 378 / 659 ( 57%)
00:28:49.138 ............................................................... 441 / 659 ( 66%)
00:28:49.490 ............................................................... 504 / 659 ( 76%)
00:28:50.840 ...SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS........................ 567 / 659 ( 86%)
00:28:54.189 ..............F................................................ 630 / 659 ( 95%)
00:29:02.563 .............................
00:29:02.724 
00:29:02.724 Time: 02:21, Memory: 38.75Mb
00:29:02.724 
00:29:02.724 There was 1 failure:
00:29:02.724 
00:29:02.724 1) Test_Tags::testIsEmpty
00:29:02.724 Failed asserting that true is false.

[tanghus]

Freakin' Oracle. Nothing but trouble

[tanghus]

Maybe if I don't catch the db exception, we can see what it's actually bitching about?

[DeepDiver1975]

Maybe if I don't catch the db exception, we can see what it's actually bitching about?

let me see if I can find it in the server logs .....

[DeepDiver1975]

as far as I can tell we have no exception or db error - might be related to the query?

[DeepDiver1975]

@butonic can you please have a quick look? Why would that fail on Oracle? THX

[tanghus]

@icewind1991 What is the correct way to do this with the new hooks system?

[ghost]

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/1168/

[tanghus]

@DeepDiver1975 Currently the manager class doesn't do anything else but instantiating objects, but that can change later if there's a need for caching them or smth.

[ghost]

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/1192/

[tanghus]

Any 👍 ? @DeepDiver1975 @georgehrke @bartv2
This change doesn't currently affect anything else than calendar and contacts.

[DeepDiver1975]

👍