Skip to content

fix some issues#10

Closed
mmattel wants to merge 2 commits into
masterfrom
new_ui_bundle
Closed

fix some issues#10
mmattel wants to merge 2 commits into
masterfrom
new_ui_bundle

Conversation

@mmattel

@mmattel mmattel commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

This PR fixes some general page issues

@mmattel mmattel added bug Something isn't working enhancement New feature or request labels Nov 13, 2018
@mmattel
mmattel requested a review from settermjd November 13, 2018 12:09
Comment thread src/partials/toolbar.hbs
{{> page-versions}}
{{#if page.editUrl}}
<div class="edit-this-page"><a href="{{page.editUrl}}">Edit this Page</a></div>
{{!-- <div class="edit-this-page"><a href="{{page.editUrl}}">Edit this Page</a></div> --}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing this, why not remove it completely? Or did I forget something that we discussed, earlier today?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to remove it at all?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmattel, can you add your reasoning here, pls?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see below

@settermjd settermjd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question.

@mmattel

mmattel commented Nov 13, 2018

Copy link
Copy Markdown
Contributor Author

Commented out instead of removing to keep it as an example

@mmattel

mmattel commented Nov 14, 2018

Copy link
Copy Markdown
Contributor Author

@tboerger I have highlighted explicitly in the footer under topic "Interact" --> "Contribute" (which points clearly and directly to the various contribution possibilities including documentation) and removed on "EVERY" page "Edit this Page".

@tboerger

Copy link
Copy Markdown
Contributor

@tboerger I have highlighted explicitly in the footer under topic "Interact" --> "Contribute" (which points clearly and directly to the various contribution possibilities including documentation) and removed on "EVERY" page "Edit this Page".

This is still something I disagree on. The Edit this page link is for me pretty useful and that should be decided by multiple people, not only by you or @settermjd ;)

@mmattel

mmattel commented Nov 14, 2018

Copy link
Copy Markdown
Contributor Author

Whom do you want to add ?

@mmattel

mmattel commented Nov 19, 2018

Copy link
Copy Markdown
Contributor Author

@tboerger @settermjd
Summarizing the reason for removing Edit this Page on every page and renaming in the footer Interact: Get Involved to Interact: Contribute is quite simple. Preventing being recognized as tinker kiosk. After being decades in enterprise environments I can proof that the documentation is a major part how a company presents itself – it is a businesscard. You will find on the majority of homepages the reference to feedback – however it is made – but not on every page the reader gets presented. How does ownCloud wants to be percieved, professional or a tinker kiosk? It is for sure that Edit this Page on every page will generate a different perception than a good visible note on the footer to contribute – which btw directly points to a page where the various contribution possibilities are described including documentation.

First time readers get a clear direction where to contribute and recurring contributers do not need it anyways.

@tboerger

Copy link
Copy Markdown
Contributor

Sorry, but calling a company a tinker kiosk because it provides a link to directly edit the page is bullshit for me. It absolutely reduces the effort how to fix typos or to add suggestions/improvements.

@mmattel

mmattel commented Nov 20, 2018

Copy link
Copy Markdown
Contributor Author

@tboerger the discussion it is about how readers can percieve this kind of link, nothing else.

@felixboehm @hodyroff
Sorry involving you. After having a talk with @settermjd I would like to ask you for your advice.
The discussion here is about having "Edit this Page" on every docs page or remove that (currently dead) link and have a more descriptive single footer link instead or any combination, please see the screenshots below:

Many thanks in advance

Keeping and fixing / removing Edit this Page:
image

Adding Contribute in the footer (links to https://owncloud.org/community/)
image

@tboerger

Copy link
Copy Markdown
Contributor

The contribute link just refers to a general guide how to contribute while the edit this page link directly guides to the right file to edit... These are totally different goals.

@mmattel

mmattel commented Dec 3, 2018

Copy link
Copy Markdown
Contributor Author

@felixboehm @hodyroff,
mind to add your comment so we can finalize

@felixboehm

Copy link
Copy Markdown

The link to edit the current page activates to contribute easily, why not? I like this personally very much, and see no disadvantage.
The link should work of course.

@settermjd

Copy link
Copy Markdown
Contributor

Thanks for the feedback, @felixboehm.

@settermjd settermjd closed this in 9282be7 Dec 5, 2018
@tboerger
tboerger deleted the new_ui_bundle branch December 6, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants