fix some issues#10
Conversation
| {{> page-versions}} | ||
| {{#if page.editUrl}} | ||
| <div class="edit-this-page"><a href="{{page.editUrl}}">Edit this Page</a></div> | ||
| {{!-- <div class="edit-this-page"><a href="{{page.editUrl}}">Edit this Page</a></div> --}} |
There was a problem hiding this comment.
If we're removing this, why not remove it completely? Or did I forget something that we discussed, earlier today?
There was a problem hiding this comment.
Why do you want to remove it at all?
There was a problem hiding this comment.
@mmattel, can you add your reasoning here, pls?
|
Commented out instead of removing to keep it as an example |
|
@tboerger I have highlighted explicitly in the footer under topic "Interact" --> "Contribute" (which points clearly and directly to the various contribution possibilities including documentation) and removed on "EVERY" page "Edit this Page". |
This is still something I disagree on. The |
|
Whom do you want to add ? |
d7cd8f6 to
33d9cdc
Compare
|
@tboerger @settermjd First time readers get a clear direction where to contribute and recurring contributers do not need it anyways. |
|
Sorry, but calling a company a tinker kiosk because it provides a link to directly edit the page is bullshit for me. It absolutely reduces the effort how to fix typos or to add suggestions/improvements. |
|
@tboerger the discussion it is about how readers can percieve this kind of link, nothing else. @felixboehm @hodyroff Many thanks in advance Keeping and fixing / removing Edit this Page: Adding Contribute in the footer (links to https://owncloud.org/community/) |
|
The contribute link just refers to a general guide how to contribute while the edit this page link directly guides to the right file to edit... These are totally different goals. |
33d9cdc to
f8f864b
Compare
|
@felixboehm @hodyroff, |
|
The link to edit the current page activates to contribute easily, why not? I like this personally very much, and see no disadvantage. |
|
Thanks for the feedback, @felixboehm. |


This PR fixes some general page issues