Skip to content

fix some issues #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmattel wants to merge 2 commits into from
Closed

fix some issues #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f864b
fix some issues
mmattel Nov 13, 2018
47ebb08
Merge branch 'master' into new_ui_bundle
settermjd Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/partials/footer-content.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
<li class="menu-irc-channel"><a href="https://webchat.freenode.net/?channels=owncloud">IRC Channel</a></li>
<li class="menu-mailing-list"><a href="https://mailman.owncloud.org/mailman/listinfo/">Mailing List</a></li>
<li class="menu-forums"><a href="https://central.owncloud.org">Forums</a></li>
<li class="menu-bug-tracker"><a href="https://owncloud.org/community">Get involved</a></li>
<li class="menu-promote"><a href="https://owncloud.org/promote/">Discuss ownCloud with others</a></li>
<li class="menu-contribute"><a href="https://owncloud.org/community">Contribute</a></li>
<li class="menu-discuss"><a href="https://owncloud.org/promote/">Discuss ownCloud with others</a></li>
</ul>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/partials/toolbar.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
{{> breadcrumbs}}
{{> page-versions}}
{{#if page.editUrl}}
<div class="edit-this-page"><a href="{{page.editUrl}}">Edit this Page</a></div>
{{!-- <div class="edit-this-page"><a href="{{page.editUrl}}">Edit this Page</a></div> --}}

@settermjd settermjd Nov 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing this, why not remove it completely? Or did I forget something that we discussed, earlier today?

@tboerger tboerger Nov 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to remove it at all?

@settermjd settermjd Nov 19, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmattel, can you add your reasoning here, pls?

@mmattel mmattel Nov 19, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see below

{{/if}}
</div>