Skip to content

Fix unit test for RecreateMasterkey#107

Closed
sharidas wants to merge 1 commit into
masterfrom
fix-unit-test-recreate-masterkey
Closed

Fix unit test for RecreateMasterkey#107
sharidas wants to merge 1 commit into
masterfrom
fix-unit-test-recreate-masterkey

Conversation

@sharidas

Copy link
Copy Markdown
Contributor

Fix unit test for RecreateMasterkey.
Use onConsecutiveCalls to get the
output printed on the console.

Signed-off-by: Sujith H sharidasan@owncloud.com

Fix unit test for RecreateMasterkey.
Use onConsecutiveCalls to get the
output printed on the console.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas added this to the development milestone Mar 11, 2019
@sharidas sharidas self-assigned this Mar 11, 2019
@sharidas
sharidas requested a review from phil-davis March 11, 2019 06:06

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharidas

Copy link
Copy Markdown
Contributor Author

@phil-davis Unfortunately backport is not required. Because it was already merged owncloud/core@3e09d96.

@PVince81

Copy link
Copy Markdown
Contributor

CI failures

@phil-davis

Copy link
Copy Markdown
Contributor

I should have put an explicit comment here! Because of the core stable10 "drop PHP 5.6", both this fix and the changes for "drop PHP 5.6" had to be combined into a single PR.

The commit in this PR has been cherry-picked and merged in PR #109

@phil-davis phil-davis closed this Mar 14, 2019
@phil-davis
phil-davis deleted the fix-unit-test-recreate-masterkey branch March 14, 2019 09:50
@patrickjahns patrickjahns removed this from the development milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants