Drop php 5.6#109
Merged
Merged
Conversation
Fix unit test for RecreateMasterkey. Use onConsecutiveCalls to get the output printed on the console. Signed-off-by: Sujith H <sharidasan@owncloud.com>
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=========================================
Coverage 64.28% 64.28%
Complexity 598 598
=========================================
Files 33 33
Lines 2212 2212
=========================================
Hits 1422 1422
Misses 790 790Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=========================================
Coverage 64.28% 64.28%
Complexity 598 598
=========================================
Files 33 33
Lines 2212 2212
=========================================
Hits 1422 1422
Misses 790 790Continue to review full report at Codecov.
|
individual-it
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core stable10 no longer supports PHP 5.6
owncloud/core#34698
and cherry-pick from #107 "Fix unit test for RecreateMasterkey" because this is also an outstanding item in order to get green CI.