Skip to content

Delete bug demonstration for quota feature from encryption app#354

Merged
phil-davis merged 3 commits into
masterfrom
deleteQuotaBugDemo
Jul 21, 2022
Merged

Delete bug demonstration for quota feature from encryption app#354
phil-davis merged 3 commits into
masterfrom
deleteQuotaBugDemo

Conversation

@SagarGi

@SagarGi SagarGi commented Jul 20, 2022

Copy link
Copy Markdown
Member

Description

This PR deletes the apiEncryption/quotaOc10Issue40140.feature from this app since the quota handling has been improved and fixed with this PR owncloud/core#39895. So The bug demonstration can be deleted as this test scenarios is run on this app with apiMain/quota.feature from core.

Related issue

#353

@SagarGi SagarGi self-assigned this Jul 20, 2022
@SagarGi SagarGi requested a review from phil-davis July 20, 2022 06:22
@phil-davis

Copy link
Copy Markdown
Contributor

Note: these tests were added to the encryption test suite in PR #346 because the quota bug behaved a little bit differently in encryption compared to core. Now that the c ore bug has been fixed, the tests in core should pass the same when run with encryption enabled, and we delete the bug-demonstration scenarios that were added in encryption.

@ownclouders

ownclouders commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiCoreMKey-40-6-master-mysql8.0-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/encryption/2571/33

@SagarGi

SagarGi commented Jul 20, 2022

Copy link
Copy Markdown
Member Author

@phil-davis https://drone.owncloud.com/owncloud/encryption/2565/33/20 this looks like a hard failure. @grgprarup is looking to it.

@SagarGi SagarGi force-pushed the deleteQuotaBugDemo branch from ff504ac to a0ef9e9 Compare July 20, 2022 08:36
@phil-davis

Copy link
Copy Markdown
Contributor

@phil-davis https://drone.owncloud.com/owncloud/encryption/2565/33/20 this looks like a hard failure. @grgprarup is looking to it.

Yes, Brian (share receiver) copies a file over the top of a file shared by Alice. The file content from Brian exceeds the quota of Alice. It is possible that in this situation Brian gets the 507 InsufficientStorage response, but the server has "made a mess" of the file.

We might need to skip that scenario on encryption for now, and report the problem in an issue.

@phil-davis

Copy link
Copy Markdown
Contributor

I also pushed some cleanup and bump of dependencies:

Makefile target "clean" was not removing the vendor directory. Add that to Makefile.

Bump bamarni/composer-bin-plugin (1.7.0 => 1.8.0)

@phil-davis

Copy link
Copy Markdown
Contributor

Some drone pipelines seemed to be hung. I cancelled the job, destroyed the old drone agents, and restarted CI.

@SagarGi

SagarGi commented Jul 21, 2022

Copy link
Copy Markdown
Member Author

https://drone.owncloud.com/owncloud/encryption/2565/33/20 this fail must pass if this PR gets merged. owncloud/core#40224 (review)

@phil-davis

Copy link
Copy Markdown
Contributor

https://drone.owncloud.com/owncloud/encryption/2571/33/20

runsh: Total unexpected failed scenarios throughout the test run:
apiMain/quota.feature:358

That has been skipped now - owncloud/core#40224

I will restart CI.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis

Copy link
Copy Markdown
Contributor

drone is being very annoying. I restarted again (20 minutes ago), because one of the pipelines seemed to be hung,

@phil-davis phil-davis merged commit 9518821 into master Jul 21, 2022
@delete-merged-branch delete-merged-branch Bot deleted the deleteQuotaBugDemo branch July 21, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants