Skip to content

use typesafe comparison#358

Merged
butonic merged 1 commit into
masterfrom
use-typesafe-comparison
Jul 27, 2022
Merged

use typesafe comparison#358
butonic merged 1 commit into
masterfrom
use-typesafe-comparison

Conversation

@butonic

@butonic butonic commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

fixes decryption errors when a block happens to be of length 1 and be "0"
can be testet with a file containing just "0" or a file containing 6073 "0":

for f in `seq 0 6072` ; do echo -n "0" >> 6073.bin ; done

@CLAassistant

CLAassistant commented Jul 21, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ownclouders

ownclouders commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiMasterKeys-master-mysql8.0-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/encryption/2573/16

@phil-davis

Copy link
Copy Markdown
Contributor

https://drone.owncloud.com/owncloud/encryption/2573/16/12

Note: we are sorting out CI in PR #354 - that will be merged as soon as CI finishes. Then PRs like this one need to be rebased.

@IljaN IljaN self-requested a review July 21, 2022 09:13

@IljaN IljaN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. LGTM 👍

@phil-davis

Copy link
Copy Markdown
Contributor

@butonic please rebase - CI should be passing now.

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the use-typesafe-comparison branch from 6706171 to ed563a6 Compare July 26, 2022 10:26
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit eadcb17 into master Jul 27, 2022
@delete-merged-branch delete-merged-branch Bot deleted the use-typesafe-comparison branch July 27, 2022 07:22
@jnweiger jnweiger mentioned this pull request Aug 1, 2022
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants