This repository was archived by the owner on Jul 14, 2026. It is now read-only.
[full-ci] Optimize share loading part II#7638
Merged
Merged
Conversation
Contributor
|
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/28342/38/1 |
JammingBen
force-pushed
the
increase-share-loading-performance
branch
from
September 13, 2022 09:26
86211a6 to
8c29a6f
Compare
JammingBen
force-pushed
the
increase-share-loading-performance
branch
from
September 14, 2022 12:16
029fa59 to
3d6a77d
Compare
JammingBen
force-pushed
the
increase-share-loading-performance
branch
from
September 14, 2022 12:20
3d6a77d to
093dfb8
Compare
JammingBen
commented
Sep 14, 2022
Comment on lines
+427
to
+428
| // FIXME: We need the storageId of each parent resource here | ||
| const spaceRef = indirect ? null : storageId |
Contributor
Author
There was a problem hiding this comment.
This is ugly... We can't take the storageId of the current resource for each of its parents. This currently results in incorrect indirect shares being displayed when both of the following applies:
a) You are in in nested folder (at least 2 levels deep)
b) You (re-)load the page within the folder. Navigating from the outside into the folder should be fine.
JammingBen
marked this pull request as ready for review
September 14, 2022 13:28
kulmann
approved these changes
Sep 19, 2022
kulmann
left a comment
Contributor
There was a problem hiding this comment.
Nice job! 💪 Only some nitpicks about mutation naming, see comments.
|
SonarCloud Quality Gate failed. |
delete-merged-branch
Bot
deleted the
increase-share-loading-performance
branch
September 19, 2022 09:11
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Continuation of #7580
loadCurrentFileOutgoingSharesandloadIncomingSharesmutations. Instead, incoming and outgoing shares are now being loaded vialoadSharesTree(). This avoidsgetShare()requests from being executed multiple times.Types of changes