This repository was archived by the owner on Jul 14, 2026. It is now read-only.
Disable shares tree cache for flat file lists#7656
Merged
Conversation
JammingBen
marked this pull request as ready for review
September 19, 2022 11:06
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shares tree caching is a problem in flat file lists that gather resources from various places (like "Shared with others", "Shared via link", ...). This is an issue because the caching currently happens purely based on the filename. However, these lists can contain multiple resources with the same name.
In the future, we should think about something else that also includes the storage ID. This is necessary anyway because of #7655.
However, we don't have any performance impact by disabling the cache here as we can't navigate into folders anyway.
Motivation and Context
Followup for #7638
Types of changes