Disable new organization button if user doesn't have write on the silo#1244
Closed
david-crespo wants to merge 1 commit into
Closed
Disable new organization button if user doesn't have write on the silo#1244david-crespo wants to merge 1 commit into
david-crespo wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
role-gating
branch
from
24407ee to
f531ea9
Compare
david-crespo
commented
Oct 20, 2022
| <Button size="sm" disabled> | ||
| New Organization | ||
| </Button> | ||
| )} |
Collaborator
Author
There was a problem hiding this comment.
Clearly this is too noisy — we'd want to wrap this up into a disable-able custom link component with a disabled prop and a message to show in a tooltip when disabled.
Contributor
There was a problem hiding this comment.
Disabled links are a bit of an odd pattern. We'd want to change the pointer and ensure we had aria-disabled present. I think it's definitely something we'd want to try out on a screen reader just to see what it resulted in.
david-crespo
force-pushed
the
role-gating
branch
from
f531ea9 to
02db030
Compare
david-crespo
commented
Oct 20, 2022
| await Promise.all([ | ||
| apiQueryClient.prefetchQuery('organizationList', { query: { limit: 10 } }), | ||
| apiQueryClient.prefetchQuery('policyView', {}), | ||
| ]) |
Collaborator
Author
There was a problem hiding this comment.
prefetch silo policy
david-crespo
commented
Oct 20, 2022
| return me && myGroups && siloPolicy | ||
| ? userRoleFromPolicies(me, myGroups.items, [siloPolicy]) | ||
| : null | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
all of these requests are prefetched and therefore never undefined, but we don't know it statically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept.