[3/6] [nexus-auth] move some types into nexus-types#6369
Merged
sunshowers merged 2 commits intoAug 19, 2024
Merged
Conversation
Created using spr 1.3.6-beta.1
sunshowers
added a commit
to sunshowers/omicron
that referenced
this pull request
Aug 17, 2024
Put them here rather than in `nexus-auth` so that the upcoming nexus-external-api crate has fewer dependencies. Pull Request: oxidecomputer#6369
sunshowers
changed the title
Contributor
Author
|
Adding Dave as well since we discussed where to put this. |
davepacheco
approved these changes
Aug 19, 2024
davepacheco
left a comment
davepacheco
left a comment
Collaborator
There was a problem hiding this comment.
This seems fine, but any reason not to put this into nexus-types?
Contributor
Author
I did consider that! IIRC it caused nexus-types to pull in a number of extra dependencies, but I'll double-check. |
Contributor
Author
|
It's only 3 extra build units ( |
Created using spr 1.3.6-beta.1
sunshowers
changed the title
sunshowers
deleted the
sunshowers/spr/nexus-auth-move-some-types-into-an-auth-types-crate
branch
sunshowers
added a commit
that referenced
this pull request
Aug 28, 2024
At long last, here's the last OpenAPI document converted into a trait: the Nexus external API. This is a fairly large change, but with all the prerequisites in place the conversion is overall pretty mechanical. I did need to move some types around, but the bulk of the PR is just adding the very large external API trait. This PR also adds a `.git-blame-ignore-revs` entry corresponding to #6372, so that the indent doesn't ruin blame in the GitHub web view. (You can configure this locally as well with `git config blame.ignoreRevsFile .git-blame-ignore-revs`.) In a subsequent PR I'll remove the old instructions. Depends on: * #6355 * #6364 * #6369 * #6370 * #6372 Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put them here rather than in
nexus-authso that the upcomingnexus-external-api crate has fewer dependencies.