[5/6] [nexus] add an indent level to external-api http entrypoints#6372
Merged
Conversation
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1
andrewjstone
approved these changes
Aug 27, 2024
andrewjstone
left a comment
andrewjstone
left a comment
Contributor
There was a problem hiding this comment.
Trusted, not verified ;)
Created using spr 1.3.6-beta.1
sunshowers
merged commit c315c1e
into
sunshowers/spr/main.nexus-add-an-indent-level-to-external-api-http-entrypoints
sunshowers
deleted the
sunshowers/spr/nexus-add-an-indent-level-to-external-api-http-entrypoints
branch
sunshowers
restored the
sunshowers/spr/nexus-add-an-indent-level-to-external-api-http-entrypoints
branch
sunshowers
deleted the
sunshowers/spr/nexus-add-an-indent-level-to-external-api-http-entrypoints
branch
Contributor
Author
|
bleargh, didn't update the branch to main (I really need to fix this in spr). re-did this in #6461 |
sunshowers
added a commit
that referenced
this pull request
Aug 28, 2024
At long last, here's the last OpenAPI document converted into a trait: the Nexus external API. This is a fairly large change, but with all the prerequisites in place the conversion is overall pretty mechanical. I did need to move some types around, but the bulk of the PR is just adding the very large external API trait. This PR also adds a `.git-blame-ignore-revs` entry corresponding to #6372, so that the indent doesn't ruin blame in the GitHub web view. (You can configure this locally as well with `git config blame.ignoreRevsFile .git-blame-ignore-revs`.) In a subsequent PR I'll remove the old instructions. Depends on: * #6355 * #6364 * #6369 * #6370 * #6372 Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going to put all this in a trait soon, and this file is so large that I'd
rather not ruin blame. With this intermediate commit, it will be possible to
add this revision to
.git-blame-ignore-revs, thereby preserving blame.The diff is very large but it's not scary, literally just adding an indent via
a module.
(I should have also done this with some of our other APIs -- lesson learned!)