fix(client-runtime): silence globalDate in thread recency groups - #124
Merged
Conversation
#121's thread recency grouping uses calendar Date APIs intentionally; Effect's globalDate diagnostic was failing typecheck on the new helpers and tests.
3 tasks
patroza
added a commit
that referenced
this pull request
Jul 28, 2026
…ment stack vp check gate (#126) #123 rewrote threadRecencyGroups and dropped the #124 Date diagnostic suppressions, which reds client-runtime typecheck on fork/changes and integration. Also document that stack rebases must run root vp check per layer and fix before advancing to the next parent. Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza
added a commit
that referenced
this pull request
Jul 29, 2026
…ment stack vp check gate (#126) #123 rewrote threadRecencyGroups and dropped the #124 Date diagnostic suppressions, which reds client-runtime typecheck on fork/changes and integration. Also document that stack rebases must run root vp check per layer and fix before advancing to the next parent. Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza
added a commit
that referenced
this pull request
Jul 29, 2026
…ment stack vp check gate (#126) #123 rewrote threadRecencyGroups and dropped the #124 Date diagnostic suppressions, which reds client-runtime typecheck on fork/changes and integration. Also document that stack rebases must run root vp check per layer and fix before advancing to the next parent. Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza
added a commit
that referenced
this pull request
Jul 29, 2026
…ment stack vp check gate (#126) #123 rewrote threadRecencyGroups and dropped the #124 Date diagnostic suppressions, which reds client-runtime typecheck on fork/changes and integration. Also document that stack rebases must run root vp check per layer and fix before advancing to the next parent. Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datecalendar math.effect(globalDate)on the new source/tests.new Date()through helpers with targeted diagnostic suppressions.Test plan