Use spec OHTTP media types - #160
Merged
Merged
Conversation
Member
Author
|
Ohttp is now |
DanGould
force-pushed
the
ohttp-media-types
branch
2 times, most recently
from
January 23, 2024 15:49
d94ef34 to
71e6ffa
Compare
Return binary type as specified in the OHTTP Draft § 3.2. See: https://ietf-wg-ohai.github.io/oblivious-http/draft-ietf-ohai-ohttp.html#name-key-configuration-media-typ
DanGould
force-pushed
the
ohttp-media-types
branch
from
January 23, 2024 15:52
71e6ffa to
f7b93a7
Compare
Before we passed a Vec<u8> and skirted some necessary type safety that could have allowed key reuse, which breaks the security of OHTTP.
DanGould
force-pushed
the
ohttp-media-types
branch
from
January 23, 2024 15:58
f7b93a7 to
1ac7cc9
Compare
DanGould
marked this pull request as ready for review
January 23, 2024 16:37
jbesraa
approved these changes
Jan 23, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #159
Some issues here depend on upstream
ohttp::KeyConfigbeingDebugandCloneand ideallyEq