Test together - #207
Merged
Merged
Conversation
DanGould
force-pushed
the
test-together
branch
3 times, most recently
from
March 11, 2024 17:51
adaca03 to
7bc20e4
Compare
This was referenced Mar 11, 2024
DanGould
force-pushed
the
test-together
branch
2 times, most recently
from
March 13, 2024 00:29
70db7a1 to
dd517f2
Compare
This lets us remove the separate binary compilation requirement. Ports are also dynamically allocated so we can eventually test in parallel. However, right now a common `localhost.der` file is used to store a shared certificate which conflicts on parallel execution.
Try reading localhost certs and key from storage before generating new ones.
Member
Author
|
This lets us finally run integration tests reliably in parallel. Should make writing #145 a small chore rather than a lift. This PR only changes tests, and I'm confident in my self-review which will be further reviewed in #160. Since it only touches tests I'm going to merge it before an independent review lands but still welcome reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the payjoin-directory lib in tests so that they can be run in parallel. This makes them much easier to reason about.