Skip to content

Bump rustls v0.22 - #192

Merged
DanGould merged 1 commit into
payjoin:masterfrom
DanGould:bump-rustls
Feb 6, 2024
Merged

Bump rustls v0.22#192
DanGould merged 1 commit into
payjoin:masterfrom
DanGould:bump-rustls

Conversation

@DanGould

@DanGould DanGould commented Feb 5, 2024

Copy link
Copy Markdown
Member

No description provided.

Comment thread payjoin/src/v2.rs
Comment on lines +196 to +202
let authority_bytes = url.host().map_or_else(Vec::new, |host| {
let mut authority = host.to_string();
if let Some(port) = url.port() {
authority.push_str(&format!(":{}", port));
}
authority.into_bytes()
});

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super annoying but the url.authority() function was removed in url v2.3. It was brought back in v2.5 and we should bring it back then, too

@DanGould
DanGould requested a review from jbesraa February 5, 2024 21:49
@DanGould
DanGould merged commit 603202b into payjoin:master Feb 6, 2024
@DanGould
DanGould deleted the bump-rustls branch February 6, 2024 16:55
@DanGould DanGould mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants