Handle response status - #284
Conversation
2290152 to
91f1a3b
Compare
91f1a3b to
94fbadb
Compare
94fbadb to
11adc2d
Compare
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
Tested with "serde" added back into the dependencies list, works fine otherwise.
11adc2d to
616dc82
Compare
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
tACK. It appears the latest hyper-rustls breaks MSRV though.
|
Yeah, I was a bit sloppy on my last push trying to rebase on master and missed the I'm working on #192 which will include a transition to hyper-1.0 transition to fix msrv without the band-aid that is pinning, but it's going to take a little while. Perhaps I'll get it done today 🤞 |
5199daf to
52a8b4d
Compare
|
While #192 does need to be addressed, that's actually not related to this exact problem, which is that reqwest 0.12.5 broke MSRV. I believe my pin is the necessary fix |
Oblivious HTTP wraps an HTTP message that contains content and control information. We were ignoring content information like status even though it is essential to the Payjoin V2 protocol. Handle it.
There's nothing to do with the response except check the status code. Do that in the process_res function.
52a8b4d to
4db618c
Compare
|
I removed had the "pin reqwest" commit since it was merged by #294 |
2 participants
Oblivious HTTP wraps an HTTP message that contains content and control information. We were ignoring content information like status even though it is essential to the Payjoin V2 protocol. Handle it.
I noticed this issue when trying to send async payjoin. Even if the directory returns a 202 ACCEPTED message to wait for the receiver's proposal, the polling stops because we try to decrypt the content (which is empty, and errors) rather than short circuit the function and return None