add postcode to variable store if we have it - #1226
Merged
Merged
Conversation
Member
|
I haven't had a chance to test this yet, but very nice catch regarding these queries not taking the postalcode into account. Should be a good fix to have. |
orangejulius
force-pushed
the
address_search_using_ids
branch
from
November 2, 2018 21:28
ad507b2 to
44b8d38
Compare
Member
|
For our history, this was first mentioned in pelias/pelias#754 (comment) |
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Nov 2, 2018
Connects pelias/api#1226 Connects pelias/query#91
This is required for the other half of postalcode matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enabled pelias/query#91 to function for
address_search_using_idsqueriesIt's a simple change, we just add
postcodedata to the query variable store if we have it.Note: although not strictly interdependent, it would be ideal to merge the query PR first and then merge this one after so it pulls in the update dependency.