improved sorting for addresses with matching postcode - #91
Merged
Conversation
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Nov 2, 2018
Connects pelias/api#1226 Connects pelias/query#91
orangejulius
approved these changes
Nov 2, 2018
orangejulius
left a comment
Member
There was a problem hiding this comment.
Looks good, and this does indeed fix the issue. Acceptance test added
…queries which prioritises addresses with a matching postcode over others
orangejulius
force-pushed
the
address_search_using_ids
branch
from
November 2, 2018 21:46
51e6f9e to
9ee7b3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was alerted to this issue when investigating an issue of poor locality matching in Australia:
The issue is that the user supplied a postcode
2204which was parsed correctly and matched record number 2.If record 2. matched on the postcode, it should really be scored as no. 1
The reason for this is that the
address_search_using_idsquery doesn't include any boosting for postalcode matches.This PR adds an extra query clause for address queries which prioritises addresses with a matching postcode over others, so they sort higher.