Add Test Vault and Fix Unknown Color - #35
Closed
Genei180 wants to merge 2 commits into
Closed
Conversation
Owner
|
Fixed in version 2.2.9. Thank you for the test cases and suggested fix! |
pull Bot
pushed a commit
to ben-vargas/supernote-obsidian-plugin
that referenced
this pull request
Jul 29, 2026
Bumps the supernote-typescript submodule to v0.5.3, which adds a visibleSurfaces filter to SupernoteAtelier.toCompositeImage() (supernote-typescript#37, fixing philips#35). SupernoteAtelierView now opens the .spd file once (openAtelierFile) and keeps the parsed SupernoteAtelier around instead of always calling the open-and-flatten-everything helper, so a checkbox toggle re-composites just the selected layers without re-parsing the sqlite database on every click. Layer labels come from SupernoteAtelier.layers when the `ls` config decoded; falls back to raw surface table names otherwise. The toggle panel is skipped for single-layer files, same "nothing to show here" logic SupernoteEmbed already uses for single-page .note files. SupernoteAtelierEmbed and the export commands keep using the simpler renderAtelierCompositeDataUrl() (open + flatten everything, no toggle state to manage) — refactored to share openAtelierFile/compositeDataUrl with the view instead of duplicating the wasm-loading boilerplate. One more item off philips#138 (viewport/zoom and device attach/upload still open).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The Bug I tried to resolve is mentioned here: #29
For easier debugging, I added a Test Vault, with a Hot Reload Plugin that Allows for Easier and Visual Debugging of the Plugin.
(Loosely Oriented on the Way the Task Obsidian Plugin does it, as I found it really Helpful)
I included a Supernote File which Reproduces the Error, and one that does not.
(Note, the one which throws the Error has just another Template in the Background, which causes the Fail)
The Error Produced is in the Submodule: https://github.com/philips/supernote-typescript.
Starting the Discussion for Resolving the Issue there: philips/supernote-typescript#3
Note:
Changed the Submodule for Better Testing.
Change the Submodule Back, when you want to accept this PR.
Side Note:
Having Trouble getting this Repo to Build and Transferred to the Vault.
Mainly, Changes in the Submodule do not get reflected when build from the Root Repo.
Somebody more Experienced with Node should look at it.