Change Error too Warning - #3
Closed
Genei180 wants to merge 1 commit into
Closed
Conversation
Owner
|
Can you add a .note file to |
Owner
|
I merged a slightly modified version with a test case in 8bba67d. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Original Error is mentioned here: philips/supernote-obsidian-plugin#29
The Conversion of the File, Errors out when adding a different Template in the Background of the Supernote File.
Just Removed the Error Thrown. This Renders the Supernote File, as expected, with no Side Effects for me.
Unfortunately, I don't have a deeper Understanding of the File Structure used by Ratta or the Code Provided here.
In my understanding, the Original Error Thrown, just seems to mean that a Color is Undefined.
On trying to understand what is missing from the Image, I tried adding it in Random Colors to the Image (Currently set too Transparent) to see what is missing.
I couldn't Identify something, as it did not render something.
At this point, I'm clueless, at what these Colors could mean in the Context of the Supernote File without having more Information about it.
If somebody could provide more Information, this would be nice.
The PR fixes the Problem for me.