Skip to content

Conversation

@SjonHortensius
Copy link

No description provided.

@sodabrew
Copy link
Collaborator

The tests seem to disagree with the expectation:

========DIFF========
013+ bool(true)
013- 
014- Warning: Memcached::setOptions(): error setting memcached option: %s in %s on line %d
015- bool(false)
========DONE========
FAIL Set options using setOptions [tests/setoptions.phpt] 

@SjonHortensius
Copy link
Author

SjonHortensius commented Jan 20, 2017

I added this test to demonstrate that setOption(prefix, somethingincorrect) is broken since it should return false; but actually returns true.

To make this test succeed; the setOption needs to be fixed

@SjonHortensius
Copy link
Author

I actually think this is fixed by #294; which casts somethingincorrect to an empty string implicitly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants