Skip to content

Cannot reset OPT_PREFIX_KEY #293 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sodabrew merged 2 commits into from
Jan 20, 2017
Merged

Cannot reset OPT_PREFIX_KEY #293 #294

sodabrew merged 2 commits into from
Jan 20, 2017

Conversation

@arjenschol
Copy link
Contributor

@arjenschol arjenschol commented Jan 19, 2017

  • ZSTR_VAL(str) == 0 should be ZSTR_LEN(str) == 0

Cannot reset OPT_PREFIX_KEY #293
b2c498e 
- ZSTR_VAL(str) == 0 should be ZSTR_LEN(str) == 0
@sodabrew
Copy link
Collaborator

sodabrew commented Jan 19, 2017

Awesome!! Could you resolve this error by adding the new test file to package.xml?

Missing tests/reset_keyprefix.phpt from package.xml

@sodabrew sodabrew added this to the PHP7 milestone Jan 19, 2017
Cannot reset OPT_PREFIX_KEY #293
7dd4ff7 
- add reset_keyprefix.phpt to package.xml
@arjenschol
Copy link
Contributor Author

arjenschol commented Jan 20, 2017

Fixed!

@SjonHortensius SjonHortensius mentioned this pull request Jan 20, 2017
Closed
@sodabrew sodabrew merged commit 7f6c333 into php-memcached-dev:master Jan 20, 2017
@SjonHortensius SjonHortensius mentioned this pull request Jan 20, 2017
Closed
@arjenschol arjenschol mentioned this pull request Jan 20, 2017
Closed
@arjenschol arjenschol deleted the reset_prefix_key branch January 23, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@arjenschol @sodabrew