Terminal exit error handling - #116
Closed
juliusmarminge wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
17 tasks
radroid
added a commit
to radroid/t3code
that referenced
this pull request
Aug 8, 2026
…eep reopened Fallout from #56, caught by re-checking the alert list after it merged rather than assuming the count only goes down. Before the sweep the tree had one nanoid@3.3.12, and GHSA pingdotgg#115/pingdotgg#116 against it sat auto-dismissed by GitHub's auto-triage rule — it was scoped as a development dependency. astro 7.2.0 restructured its tree, adding an already-fixed nanoid@3.3.17 alongside the old copy and flipping that copy's scope to runtime, which took it out from under the rule and reopened both alerts. The sweep did not introduce a vulnerability — 3.3.12 was there before and was always affected — but it turned a suppressed finding into a live one. One override, "nanoid@3": ^3.3.17, dedupes onto the version already in the tree. Both advisories want <= 3.3.17, so this clears both. Ledger figures refreshed in the same commit per SEAMS.md's self-reference rule.
github-actions Bot
pushed a commit
to radroid/t3code
that referenced
this pull request
Aug 10, 2026
…eep reopened Fallout from #56, caught by re-checking the alert list after it merged rather than assuming the count only goes down. Before the sweep the tree had one nanoid@3.3.12, and GHSA pingdotgg#115/pingdotgg#116 against it sat auto-dismissed by GitHub's auto-triage rule — it was scoped as a development dependency. astro 7.2.0 restructured its tree, adding an already-fixed nanoid@3.3.17 alongside the old copy and flipping that copy's scope to runtime, which took it out from under the rule and reopened both alerts. The sweep did not introduce a vulnerability — 3.3.12 was there before and was always affected — but it turned a suppressed finding into a live one. One override, "nanoid@3": ^3.3.17, dedupes onto the version already in the tree. Both advisories want <= 3.3.17, so this clears both. Ledger figures refreshed in the same commit per SEAMS.md's self-reference rule.
radroid
added a commit
to radroid/t3code
that referenced
this pull request
Aug 10, 2026
…eep reopened Fallout from #56, caught by re-checking the alert list after it merged rather than assuming the count only goes down. Before the sweep the tree had one nanoid@3.3.12, and GHSA pingdotgg#115/pingdotgg#116 against it sat auto-dismissed by GitHub's auto-triage rule — it was scoped as a development dependency. astro 7.2.0 restructured its tree, adding an already-fixed nanoid@3.3.17 alongside the old copy and flipping that copy's scope to runtime, which took it out from under the rule and reopened both alerts. The sweep did not introduce a vulnerability — 3.3.12 was there before and was always affected — but it turned a suppressed finding into a live one. One override, "nanoid@3": ^3.3.17, dedupes onto the version already in the tree. Both advisories want <= 3.3.17, so this clears both. Ledger figures refreshed in the same commit per SEAMS.md's self-reference rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-close the terminal on exit and suppress benign write errors that occur during shutdown.
Commands like
exitshould gracefully close the terminal without displaying error messages, treating such "failures" as normal terminal behavior rather than hard errors.Note
Handle terminal exit errors by invoking
components.TerminalViewportProps.onCloseTerminalfromcomponents.TerminalViewportand remove system messages in ThreadTerminalDrawer.tsxAdd
onCloseTerminaltocomponents.TerminalViewportPropsand call it when write errors matchterminal-errors.isIgnorableTerminalWriteErroror onexited; updateThreadTerminalDrawerto pass the callback; add tests forisIgnorableTerminalWriteErrorand implement the utility in terminal-errors.ts.📍Where to Start
Start with the
TerminalViewportcomponent changes in ThreadTerminalDrawer.tsx, then reviewisIgnorableTerminalWriteErrorin terminal-errors.ts.Macroscope summarized 7dc0ff1.