chore(deps): dedupe nanoid onto 3.3.17, closing the two alerts the sweep reopened - #57
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallout from #56, caught by re-checking the alert list after it merged rather than assuming the count only goes down.
Before the sweep the tree had one
nanoid@3.3.12, and GHSA pingdotgg#115 / pingdotgg#116 against it sat auto-dismissed by GitHub's auto-triage rule — it was scoped as a development dependency. astro 7.2.0 restructured its dependency tree, which did two things: it added a second, already-fixednanoid@3.3.17alongside the old copy, and it flipped the old copy's scope to runtime. That took it out from under the auto-dismiss rule, and both alerts reopened.So the sweep did not introduce a vulnerability —
3.3.12was there before and was always affected — but it did change a suppressed finding into a live one, which is my problem to close either way.One override,
"nanoid@3": ^3.3.17, dedupes the two copies onto the version that was already in the tree. Both advisories want ≤ 3.3.17 (< 3.3.16and< 3.3.17), so this clears both. Lockfile moves by 14 lines.Ledger figures refreshed in the same commit, per SEAMS.md's self-reference rule: row 37 to +23 / risk 667,
pnpm-lock.yamlto +318/-737 / risk 67520, header to 37 files / +1949 / -925.Takes the repo to 6 open alerts, from 107 at the start of this cleanup.