Skip to content

Add configurable terminal font setting - #1572

Closed
p0pmann wants to merge 4 commits into
pingdotgg:mainfrom
p0pmann:feat/terminal-font
Closed

Add configurable terminal font setting#1572
p0pmann wants to merge 4 commits into
pingdotgg:mainfrom
p0pmann:feat/terminal-font

Conversation

@p0pmann

@p0pmann p0pmann commented Mar 30, 2026

Copy link
Copy Markdown

What Changed

A new Terminal font setting added under Settings > General that lets users provide a custom CSS font-family stack for the terminal.

The setting is persisted in client settings, defaults to the existing terminal font stack, normalizes blank values back to that default, and applies live to open terminal instances without restarting them.

This is scoped to terminal font configuration only. It does not bundle fonts, validate installed fonts, or change fonts used elsewhere in the app.

Why

The terminal currently uses a fixed hardcoded font stack. That works for basic monospace rendering, but it makes it hard to use shells and prompt themes that rely on Nerd Fonts or other glyph-complete fonts, especially for zsh and oh-my-posh setups.

UI Changes

Before:

image image

After:

image

Terminal with "FiraCode Nerd Font Mono", monospace
image

Screen.Recording.2026-03-30.at.1.35.14.PM-1.mov

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Add configurable terminal font family setting to the General settings panel

  • Adds a terminalFontFamily field to ClientSettingsSchema in settings.ts with trimming, blank fallback to DEFAULT_TERMINAL_FONT_FAMILY, and a 1024-char max.
  • Adds a 'Terminal font' input row to the General settings panel, with a reset action to restore the default font stack.
  • The terminal in ThreadTerminalDrawer.tsx initializes with the user's font setting and updates live on change via applyTerminalFontFamily, which refits and refreshes the terminal.
  • Extends legacy settings migration to normalize and persist terminalFontFamily when migrating from local storage.

Macroscope summarized 16c45d1.

@coderabbitai

coderabbitai Bot commented Mar 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 716a948d-83ab-43df-a91b-bb33c35ddb2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 30, 2026
Comment thread apps/web/src/components/ThreadTerminalDrawer.tsx
@juliusmarminge

Copy link
Copy Markdown
Member

proper appearance system in the works so don't wanna add one-off settings like this until we have that in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants