Add terminal Nerd Font fallbacks - #1919
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review Minor font-family configuration change that adds Nerd Font fallbacks. An unresolved comment notes that 'JetBrains Mono' was inadvertently removed from the original font stack, which may be a regression worth addressing. You can customize Macroscope's approvability policy. Learn more. |
443d780 to
044970f
Compare
044970f to
4bbee03
Compare
Dismissing prior approval to re-evaluate 4bbee03
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4bbee03. Configure here.
| '"JetBrainsMono Nerd Font Mono"', | ||
| '"JetBrainsMono NF"', | ||
| "monospace", | ||
| ].join(", "); |
There was a problem hiding this comment.
Removed JetBrains Mono fallback
Low Severity
The new TERMINAL_FONT_FAMILY list drops "JetBrains Mono", which was in the previous inline fontFamily string. On setups where that was the first installed face in the stack, the terminal no longer uses it and may fall through to generic monospace, contrary to preserving the prior default fonts before Nerd Font fallbacks.
Reviewed by Cursor Bugbot for commit 4bbee03. Configure here.
|
superseded by #4860 |


What changed
Adds a named terminal font-family stack for the thread terminal that preserves the existing default fonts first, then adds common Nerd Font fallbacks before the final generic
monospacefallback.This keeps the current default appearance where
SF Mono,Consolas,Liberation Mono, orMenlowork, while allowing Powerline/Nerd Font prompt glyphs to render when an installed Nerd Font can cover missing glyphs.Closes #1918.
Why
The integrated terminal currently ends its fixed font stack at generic
monospace. On Linux, shell prompts that use Nerd Font or Powerline glyphs can render as boxes/unknown characters even when a compatible Nerd Font is installed.This is intentionally not a configurable terminal-font setting. PR #1572 was closed because a broader appearance system is planned; this PR only adds fallback fonts to the existing stack.
UI notes
Before, prompt glyphs render as boxes/unknown characters:
After, installed Nerd Font fallbacks cover the prompt glyphs:
The screenshots are cropped to show only the terminal prompt area.
Validation
bun fmtbun lintpasses with one existingeslint-plugin-unicorn(consistent-function-scoping)warning inapps/web/src/environments/runtime/catalog.test.tsbun typecheckpasses with Bun 1.3.9 and Node 24.13.1Note
Add Nerd Font fallbacks to the terminal font-family in
ThreadTerminalDrawerExtracts the terminal
fontFamilystring into aTERMINAL_FONT_FAMILYconstant in ThreadTerminalDrawer.tsx and addsMesloLGS NF,JetBrainsMono Nerd Font Mono, andJetBrainsMono NFas fallbacks. This ensures Nerd Font glyphs (e.g. icons in shell prompts) render correctly for users who have these fonts installed.Macroscope summarized 4bbee03.
Note
Low Risk
Presentation-only change to xterm font fallbacks in the thread terminal; no auth, data, or terminal I/O behavior changes.
Overview
The thread terminal’s xterm
fontFamilyis moved into a sharedTERMINAL_FONT_FAMILYconstant and wired intoTerminalViewportinstead of an inline string.The stack still prefers the same system monospaces first (
SF Mono,Consolas,Liberation Mono,Menlo), then adds Nerd Font fallbacks (MesloLGS NF, JetBrains Nerd variants) before genericmonospace, so Powerline/Nerd prompt glyphs can render when those fonts are installed—especially on Linux—without changing default typography when they are not. The old inline list included JetBrains Mono (non-Nerd); that name is dropped in favor of the explicit Nerd Font entries.Reviewed by Cursor Bugbot for commit 4bbee03. Bugbot is set up for automated code reviews on this repo. Configure here.