Skip to content

Add terminal Nerd Font fallbacks - #1919

Closed
Specter242 wants to merge 1 commit into
pingdotgg:mainfrom
Specter242:codex/terminal-nerd-font-fallback
Closed

Add terminal Nerd Font fallbacks#1919
Specter242 wants to merge 1 commit into
pingdotgg:mainfrom
Specter242:codex/terminal-nerd-font-fallback

Conversation

@Specter242

@Specter242 Specter242 commented Apr 11, 2026

Copy link
Copy Markdown

What changed

Adds a named terminal font-family stack for the thread terminal that preserves the existing default fonts first, then adds common Nerd Font fallbacks before the final generic monospace fallback.

This keeps the current default appearance where SF Mono, Consolas, Liberation Mono, or Menlo work, while allowing Powerline/Nerd Font prompt glyphs to render when an installed Nerd Font can cover missing glyphs.

Closes #1918.

Why

The integrated terminal currently ends its fixed font stack at generic monospace. On Linux, shell prompts that use Nerd Font or Powerline glyphs can render as boxes/unknown characters even when a compatible Nerd Font is installed.

This is intentionally not a configurable terminal-font setting. PR #1572 was closed because a broader appearance system is planned; this PR only adds fallback fonts to the existing stack.

UI notes

Before, prompt glyphs render as boxes/unknown characters:

Terminal prompt before fallback fonts, showing missing glyph boxes

After, installed Nerd Font fallbacks cover the prompt glyphs:

Terminal prompt after fallback fonts, showing glyphs rendered

The screenshots are cropped to show only the terminal prompt area.

Validation

  • bun fmt
  • bun lint passes with one existing eslint-plugin-unicorn(consistent-function-scoping) warning in apps/web/src/environments/runtime/catalog.test.ts
  • bun typecheck passes with Bun 1.3.9 and Node 24.13.1

Note

Add Nerd Font fallbacks to the terminal font-family in ThreadTerminalDrawer

Extracts the terminal fontFamily string into a TERMINAL_FONT_FAMILY constant in ThreadTerminalDrawer.tsx and adds MesloLGS NF, JetBrainsMono Nerd Font Mono, and JetBrainsMono NF as fallbacks. This ensures Nerd Font glyphs (e.g. icons in shell prompts) render correctly for users who have these fonts installed.

Macroscope summarized 4bbee03.


Note

Low Risk
Presentation-only change to xterm font fallbacks in the thread terminal; no auth, data, or terminal I/O behavior changes.

Overview
The thread terminal’s xterm fontFamily is moved into a shared TERMINAL_FONT_FAMILY constant and wired into TerminalViewport instead of an inline string.

The stack still prefers the same system monospaces first (SF Mono, Consolas, Liberation Mono, Menlo), then adds Nerd Font fallbacks (MesloLGS NF, JetBrains Nerd variants) before generic monospace, so Powerline/Nerd prompt glyphs can render when those fonts are installed—especially on Linux—without changing default typography when they are not. The old inline list included JetBrains Mono (non-Nerd); that name is dropped in favor of the explicit Nerd Font entries.

Reviewed by Cursor Bugbot for commit 4bbee03. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 59d713ff-80e7-43c8-ae0d-7d2766ee4b8c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
@Specter242 Specter242 changed the title [codex] Add terminal Nerd Font fallbacks Add terminal Nerd Font fallbacks Apr 11, 2026
@Specter242
Specter242 marked this pull request as ready for review April 11, 2026 03:02
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Apr 11, 2026
@macroscopeapp

macroscopeapp Bot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

Minor font-family configuration change that adds Nerd Font fallbacks. An unresolved comment notes that 'JetBrains Mono' was inadvertently removed from the original font stack, which may be a regression worth addressing.

You can customize Macroscope's approvability policy. Learn more.

@Specter242
Specter242 force-pushed the codex/terminal-nerd-font-fallback branch from 443d780 to 044970f Compare April 12, 2026 00:53
@juliusmarminge
juliusmarminge force-pushed the codex/terminal-nerd-font-fallback branch from 044970f to 4bbee03 Compare June 16, 2026 18:35
@macroscopeapp
macroscopeapp Bot dismissed their stale review June 16, 2026 18:35

Dismissing prior approval to re-evaluate 4bbee03

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4bbee03. Configure here.

'"JetBrainsMono Nerd Font Mono"',
'"JetBrainsMono NF"',
"monospace",
].join(", ");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed JetBrains Mono fallback

Low Severity

The new TERMINAL_FONT_FAMILY list drops "JetBrains Mono", which was in the previous inline fontFamily string. On setups where that was the first installed face in the stack, the terminal no longer uses it and may fall through to generic monospace, contrary to preserving the prior default fonts before Nerd Font fallbacks.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4bbee03. Configure here.

@t3-code

t3-code Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

superseded by #4860

@t3-code t3-code Bot closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal font stack lacks Nerd Font fallbacks for prompt glyphs

1 participant