Skip to content

Add terminal Nerd Font fallbacks #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Specter242 wants to merge 1 commit into from
+13 −2
Closed

Add terminal Nerd Font fallbacks #1919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions apps/web/src/components/ThreadTerminalDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,18 @@ import { openDiscoveredPort } from "./preview/openDiscoveredPort";
const MIN_DRAWER_HEIGHT = 180;
const MAX_DRAWER_HEIGHT_RATIO = 0.75;
const MULTI_CLICK_SELECTION_ACTION_DELAY_MS = 260;
const TERMINAL_FONT_FAMILY = [
'"SF Mono"',
'"SFMono-Regular"',
"Consolas",
'"Liberation Mono"',
"Menlo",
// Keep the default terminal fonts first; Nerd Font fallbacks cover prompt glyphs when available.
'"MesloLGS NF"',
'"JetBrainsMono Nerd Font Mono"',
'"JetBrainsMono NF"',
"monospace",
].join(", ");

@cursor cursor Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed JetBrains Mono fallback

Low Severity

The new TERMINAL_FONT_FAMILY list drops "JetBrains Mono", which was in the previous inline fontFamily string. On setups where that was the first installed face in the stack, the terminal no longer uses it and may fall through to generic monospace, contrary to preserving the prior default fonts before Nerd Font fallbacks.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4bbee03. Configure here.


function maxDrawerHeight(): number {
if (typeof window === "undefined") return DEFAULT_THREAD_TERMINAL_HEIGHT;
Expand Down Expand Up @@ -342,8 +354,7 @@ export function TerminalViewport({
lineHeight: 1,
fontSize: 12,
scrollback: 5_000,
fontFamily:
'"SF Mono", "SFMono-Regular", "JetBrains Mono", Consolas, "Liberation Mono", Menlo, monospace',
fontFamily: TERMINAL_FONT_FAMILY,
theme: terminalThemeFromApp(mount),
});
terminal.loadAddon(fitAddon);
Expand Down
Loading