[codex] refactor desktop Electron Effect services

[juliusmarminge]

Summary

The desktop Electron adapters retained standalone *Shape interfaces and inconsistent placement of their service construction. Their custom operational errors also used Data.TaggedError, which kept them outside the schema-backed error conventions used by the target Effect modules.

This change standardizes the nine Electron adapter services without changing their runtime behavior. Each service now defines its contract inline on Context.Service and exports both its real make value and canonical export const layer = Layer.... Electron service consumers use module namespaces such as ElectronSafeStorage.layer instead of named or aliased layer imports. Static service values use Layer.succeed, while Menu, Protocol, and Window retain Layer.effect for their effectful constructors. Test implementations reference Service["Service"] instead of separately exported shape types.

The protocol, safe-storage, updater, and window errors now use Schema.TaggedErrorClass with structured fields and getter-based messages derived from their scheme and cause attributes.

User impact

There is no intentional user-visible behavior change. The migration makes desktop service construction and test-layer typing predictable, reduces duplicate public type names, and makes Electron adapter errors compatible with the schema-backed Effect patterns used elsewhere in the repository.

Root cause

These adapters were introduced at different points in the desktop implementation and retained older service-definition patterns. As a result, service contracts, constructors, layers, and errors were expressed inconsistently even though they serve the same infrastructure role.

Validation

• vp test apps/desktop/src/electron apps/desktop/src/app/DesktopAppIdentity.test.ts apps/desktop/src/app/DesktopConnectionCatalogStore.test.ts apps/desktop/src/settings/DesktopSavedEnvironments.test.ts apps/desktop/src/updates/DesktopUpdates.test.ts apps/desktop/src/window/DesktopApplicationMenu.test.ts apps/desktop/src/window/DesktopWindow.test.ts — 14 files and 47 tests passed
• vp run --filter @t3tools/desktop typecheck — passed
• vp check — passed with 0 errors; 20 existing warnings remain outside this change
• vp run typecheck — all 15 workspace tasks passed

---

Note

Low Risk
Mechanical refactor with tests updated; the only behavioral API change is errors no longer exposing operation and broader union types for safe-storage failures.

Overview
Standardizes the desktop Electron adapter modules so each service declares its contract inline on Context.Service, exports a shared make plus layer, and drops separate *Shape interfaces. Tests and mocks now type against Service["Service"] instead of exported shape types.

Operational errors move from Data.TaggedError to Schema.TaggedErrorClass (protocol, safe storage, updater, window), with ElectronSafeStorageError / ElectronUpdaterError unions for higher-level callers. Connection catalog and saved environments errors lose the redundant operation field; consumers still distinguish failures by error class and paths/messages.

Call sites pick up small import cleanups (makeComponentLogger, named IPC channel constants, ElectronSafeStorage in main). Intended runtime behavior is unchanged aside from error instance shape.

^{Reviewed by Cursor Bugbot for commit 83049f1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Refactor desktop Electron Effect services to use Schema.TaggedErrorClass and inlined service shapes

• Replaces Data.TaggedError with Schema.TaggedErrorClass (with Schema.Defect-typed causes) across Electron service error classes in ElectronSafeStorage, ElectronUpdater, ElectronWindow, ElectronProtocol, and related modules.
• Removes the operation literal field from error schemas in DesktopConnectionCatalogStore, DesktopSavedEnvironments, and related files; updates tests accordingly.
• Consolidates error types for ElectronSafeStorage and ElectronUpdater into exported union types (ElectronSafeStorageError, ElectronUpdaterError) with type guards, replacing previously distinct per-operation error types.
• Inlines service shapes directly into Context.Service generic parameters across all Electron service modules, removing separate shape interfaces.
• Exports make factories directly from each Electron service module instead of using local constants.

^{Macroscope summarized 83049f1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b1b8cc4f-0317-40bf-be66-faef1ab75803

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-service-desktop-electron

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Expo continuous deployment is ready!

• Project → t3-code
• Platforms → android, ios
• Scheme → t3code-preview

	🤖 Android	🍎 iOS
Fingerprint	fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea	ae3bd597809dfd7771d0898f735d172973d4c1c8
Build Details	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea App version: 0.1.0 Git commit: e8196d911574887a26f0db9577a0cf70fdd3ffa1	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 App version: 0.1.0 Git commit: d5d0b2332c4f1477d040363277fa6c2639bb84b8
Update Details	Update Permalink Details Branch: pr-3178 Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea Git commit: e8196d911574887a26f0db9577a0cf70fdd3ffa1	Update Permalink Details Branch: pr-3178 Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 Git commit: e8196d911574887a26f0db9577a0cf70fdd3ffa1
Update QR

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactoring that inlines interface definitions, migrates error classes to Schema.TaggedErrorClass, removes unused error fields, and reorganizes imports. No runtime behavior changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 87e7f6a

Dismissing prior approval to re-evaluate 8c55db2

Dismissing prior approval to re-evaluate 1f27f63

Dismissing prior approval to re-evaluate b92382f

Dismissing prior approval to re-evaluate 6f8045c

Dismissing prior approval to re-evaluate b46a900

Dismissing prior approval to re-evaluate d8475f9

Dismissing prior approval to re-evaluate c71febf

[macroscopeapp]

One convention finding on the otherwise clean Effect service refactor. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate 83049f1