[codex] refactor desktop Electron Effect services (#3178)#120
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
…3387) Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
…pstream-20260620-structured-errors-a
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39470e69c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export function isCommandMissingCause(error: unknown): boolean { | ||
| if (isProviderCommandNotFoundError(error)) return true; | ||
| return error instanceof PlatformError.PlatformError && error.reason._tag === "NotFound"; |
There was a problem hiding this comment.
Preserve missing-command detection for Droid probes
When the Droid provider checks a missing CLI, DroidProvider still converts the failure to const message = ... and calls isCommandMissingCause({ message }); after this change that wrapper is no longer recognized, so ENOENT/not found failures are reported as an installed-but-failing Droid CLI instead of "not installed". Either keep supporting the legacy message-shaped input or update the Droid probe to pass the original ProviderCommandNotFoundError/PlatformError into this helper.
Useful? React with 👍 / 👎.

What Changed
Why
UI Changes
Checklist